Page MenuHomeFreeBSD

Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems.
ClosedPublic

Authored by brooks on Mar 12 2018, 9:25 PM.
Tags
None
Referenced Files
F170114069: D14673.diff
Thu, Sep 3, 1:33 PM
Unknown Object (File)
Wed, Sep 2, 4:28 AM
Unknown Object (File)
Wed, Sep 2, 1:46 AM
Unknown Object (File)
Tue, Sep 1, 12:09 PM
Unknown Object (File)
Mon, Aug 31, 4:44 AM
Unknown Object (File)
Mon, Aug 31, 3:10 AM
Unknown Object (File)
Sun, Aug 30, 7:04 PM
Unknown Object (File)
Sun, Aug 30, 10:10 AM
Subscribers

Details

Summary

For _IO() ioctls, addr is a pointer to uap->data which is a caddr_t.
When the caddr_t stores an int, dereferencing addr as an (int *) results
in truncation on little-endian 64-bit systems and corruption (owing to
extracting top bits) on big-endian 64-bit systems. In practice the
value of chan was probably always zero on systems of the latter type.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It makes some sense to me, but I suspect that this code is generally dead, since I don't know any user-space tool using it. Ken, do you?

This revision is now accepted and ready to land.Mar 12 2018, 9:46 PM
brooks retitled this revision from Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systemss to Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems..Mar 12 2018, 11:05 PM
This revision was automatically updated to reflect the committed changes.