Page MenuHomeFreeBSD

Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems.
ClosedPublic

Authored by brooks on Mar 12 2018, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 12:27 PM
Unknown Object (File)
Wed, Oct 1, 11:53 PM
Unknown Object (File)
Mon, Sep 22, 11:27 AM
Unknown Object (File)
Sep 12 2025, 1:05 AM
Unknown Object (File)
Sep 7 2025, 4:58 AM
Unknown Object (File)
Sep 6 2025, 1:23 PM
Unknown Object (File)
Aug 29 2025, 8:11 PM
Unknown Object (File)
Aug 25 2025, 10:23 AM
Subscribers

Details

Summary

For _IO() ioctls, addr is a pointer to uap->data which is a caddr_t.
When the caddr_t stores an int, dereferencing addr as an (int *) results
in truncation on little-endian 64-bit systems and corruption (owing to
extracting top bits) on big-endian 64-bit systems. In practice the
value of chan was probably always zero on systems of the latter type.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It makes some sense to me, but I suspect that this code is generally dead, since I don't know any user-space tool using it. Ken, do you?

This revision is now accepted and ready to land.Mar 12 2018, 9:46 PM
brooks retitled this revision from Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systemss to Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems..Mar 12 2018, 11:05 PM
This revision was automatically updated to reflect the committed changes.