Page MenuHomeFreeBSD

Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems.
ClosedPublic

Authored by brooks on Mar 12 2018, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 3:13 PM
Unknown Object (File)
Jan 23 2024, 9:52 PM
Unknown Object (File)
Jan 13 2024, 3:37 AM
Unknown Object (File)
Jan 9 2024, 10:52 AM
Unknown Object (File)
Dec 29 2023, 4:24 AM
Unknown Object (File)
Dec 20 2023, 1:50 AM
Unknown Object (File)
Dec 3 2023, 2:55 PM
Unknown Object (File)
Nov 5 2023, 6:42 PM
Subscribers

Details

Summary

For _IO() ioctls, addr is a pointer to uap->data which is a caddr_t.
When the caddr_t stores an int, dereferencing addr as an (int *) results
in truncation on little-endian 64-bit systems and corruption (owing to
extracting top bits) on big-endian 64-bit systems. In practice the
value of chan was probably always zero on systems of the latter type.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It makes some sense to me, but I suspect that this code is generally dead, since I don't know any user-space tool using it. Ken, do you?

This revision is now accepted and ready to land.Mar 12 2018, 9:46 PM
brooks retitled this revision from Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systemss to Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems..Mar 12 2018, 11:05 PM
This revision was automatically updated to reflect the committed changes.