Page MenuHomeFreeBSD

www/chromium: add CUPS option
ClosedPublic

Authored by leres on Mar 11 2018, 7:48 PM.

Details

Summary

Proposed commit message:

Add a CUPS option to disable cups support and remove the
dependency on print/cups. This includes a patch from cpm@
that solves an undefined linker reference that occurs when
cups is disabled. Since chromium does not support printing
without cups enabling this option also disables printing and
print previews. 

PR: 226505
Reviewed by: ?
Approved by: ?
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leres created this revision.Mar 11 2018, 7:48 PM
leres edited the summary of this revision. (Show Details)Mar 11 2018, 7:56 PM

This looks OK, on the face of it, although I'm having some (hopefully temporary) local troubles getting a test build to work.
Are you in contact with the chromium@ developers? According to https://wiki.freebsd.org/Chromium that's rene@freebsd.org or cpm@freebsd.org:
it might be worth adding them as reviewers.

matthew accepted this revision.Mar 12 2018, 7:28 AM

Ah -- I see cpm@ has commented on the bugzilla PR. Remember to add him to the Approved by: line when you commit.
lgtm

This revision is now accepted and ready to land.Mar 12 2018, 7:28 AM
This revision was automatically updated to reflect the committed changes.