Update to 3.0.0-a4.243
Fix compilation issue (iconv)
Remove GNU configure options
Details
- Reviewers
dvl feld mat - Commits
- rP465089: Unbreak and update to 3.0.0-a4.243
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I'm kinda new at this so please have that in mind, I'm not sure how docs are handled (plist).
hyperscan doesn't have a toggle, it gets auto detected same goes for flatbuffers.
snort3/Makefile | ||
---|---|---|
46โ55 | Out of order. See Chapter 15. Order of Variables in Port Makefiles. | |
60 | Why +=? | |
69โ70 | Remove. |
snort3/Makefile | ||
---|---|---|
35 | Try not to leave out commented out bits when you submit the patch in the end. | |
60 | his should go with the other helpers, they should be alphabetically sorted. Side note, it looks like it is an auto-activated feature, which is bad. You should have some _CMAKE_BOOL or _CONFIGURE_* or something to add too so that it is enabled/disabled when the option is selected and not when the library is present. | |
62 | This should go with the OPTIONS_DEFINE earlier. |
snort3/Makefile | ||
---|---|---|
60 | There's no option for that currently in upstream, it's autodetected only and that includes other libraries such as lzma. |
That builds here: https://services.unixathome.org/poudriere/data/111amd64-working/2018-03-18_22h07m20s/logs/snort3-3.0.0.a4.243_1.log
I'll get Mark to look at this tomorrow, and if he approves, I'll commit it.