Page MenuHomeFreeBSD
Differential D14576

New port: security/teleport
ClosedPublic
Actions

Authored by seanc on Mar 3 2018, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 30 2024, 8:53 AM
Unknown Object (File)
Nov 28 2024, 5:54 AM
Unknown Object (File)
Nov 14 2024, 11:16 PM
Unknown Object (File)
Oct 30 2024, 11:53 AM
Unknown Object (File)
Oct 26 2024, 7:21 AM
Unknown Object (File)
Oct 23 2024, 12:45 AM
Unknown Object (File)
Oct 12 2024, 7:41 AM
Unknown Object (File)
Oct 9 2024, 9:05 PM
View All Files
Subscribers
mat
pi
yuri

Details

Reviewers
swills
pi
mat
Commits
rP468360: Add new port: security/teleport
Summary

I finally got around to making a port of Gravitational's teleport.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

seanc created this revision.Mar 3 2018, 5:22 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 3 2018, 5:22 PM
seanc updated this revision to Diff 39919.Mar 3 2018, 5:26 PM

Added links to documentation in pkg-message

yuri added a subscriber: yuri.Mar 3 2018, 5:56 PM

Bugzilla record: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219332

pi requested changes to this revision.Mar 3 2018, 6:45 PM
pi added a subscriber: pi.

It needs ${LOCALBASE}/bin/zip:archivers/zip as a build-depend.

This revision now requires changes to proceed.Mar 3 2018, 6:45 PM
seanc updated this revision to Diff 39928.Mar 4 2018, 12:12 AM

Updated the rc script and added BUILD_DEPENDS

seanc added a comment.Mar 4 2018, 5:45 PM
In D14576#305959, @pi wrote:

It needs ${LOCALBASE}/bin/zip:archivers/zip as a build-depend.

Can you give this a once over? I used a clean room environment and found this issue as well.

seanc updated this revision to Diff 39950.Mar 5 2018, 8:39 AM

Updated rc script's teleport_roles to use the --roles flag.

mat added inline comments.Mar 5 2018, 3:09 PM
security/teleport/Makefile
4–5

Should be:

DISTVERSIONPREFIX=  v
DISTVERSION= 2.5.0-rc.2
7

Remove.

17

Out of order. See Chapter 15. Order of Variables in Port Makefiles.

32

Why?

security/teleport/files/teleport.in
27

Better provide a *_config variable and an optional *_args.

seanc updated this revision to Diff 41677.EditedApr 20 2018, 7:09 AM

Address feedback from @mat.

seanc updated this revision to Diff 41678.Apr 20 2018, 7:21 AM
seanc marked 4 inline comments as done.
seanc added a reviewer: mat.
seanc added inline comments.
security/teleport/Makefile
32

There is additional data in the binary itself that is removed when this program is installed and stripped. iirc, all of the web assets are removed if the binary is stripped.

seanc updated this revision to Diff 41744.Apr 23 2018, 7:20 AM

portlint -A turned up some items that weren't visible previously with just portlint.

seanc marked 2 inline comments as done.Apr 23 2018, 9:16 AM

@pi /@mat: could you give this another once over based on the feedback and changes above?

swills accepted this revision.Apr 26 2018, 3:07 PM

Approved

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2018, 5:32 PM
Closed by commit rP468360: Add new port: security/teleport (authored by seanc). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added inline comments.May 14 2018, 10:46 PM
head/security/teleport/Makefile
13 ↗(On Diff #41896)

Remove LOCALBASE/bin/ for go.

20 ↗(On Diff #41896)

Remove.

31 ↗(On Diff #41896)

Why ?

Revision Contents
Changeset List

PathSize
security/
1 line
teleport/
62 lines
3 lines
files/
22 lines
36 lines
18 lines

Diff 39950

View Options

security/Makefile

Loading...
View Options

security/teleport/Makefile

Loading...
View Options

security/teleport/distinfo

Loading...
View Options

security/teleport/files/pkg-message.in

Loading...
View Options

security/teleport/files/teleport.in

Loading...
View Options

security/teleport/pkg-descr

Loading...