There are some _write callbacks left only returning EROFS, replace them
by null_write. return EROFS from null_write().
Details
Details
- Reviewers
cem imp kan - Commits
- rS330056: libsa: replace remaining _write callbacks by null_write
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| stand/libsa/tftp.c | ||
|---|---|---|
| 81 ↗ | (On Diff #39758) | From a technical standpoint, there's nothing that prevents the tftp code from having write method. I don't know that it would be terribly useful (except maybe for 'nextboot' type support). Perhaps a comment is warranted here, to note that it could be done, it's just a SMOP (small matter of programming). |
| stand/libsa/tftp.c | ||
|---|---|---|
| 81 ↗ | (On Diff #39758) | Yes, same for other filesystems too, except that it is rather confusing for user, unfortunately. Also specifically for tftp, it is quite common practice to keep tftpboot tree read only and tftpd service running with minimal rights... So it is not just about having the code not written, but we would rather keep it not written. |
| stand/libsa/tftp.c | ||
|---|---|---|
| 81 ↗ | (On Diff #39758) | Not necessarily all other filesystems. iso9660 is probably exclusively RO. |
Comment Actions
No objection. I don't think these error codes actually trickle into anywhere user visible (or to any process that cares, other than != 0).