New port: databases/usql: Universal command-line interface for SQL databases
ClosedPublic
Actions

Authored by yuri on Feb 25 2018, 9:48 AM.

Details

Reviewers

tcberner
adamw

Commits

rP463561: New port: databases/usql: Universal command-line interface for SQL databases

Summary

Universal command-line interface for SQL databases

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Feb 25 2018, 9:48 AM

Herald added a subscriber: mat. · View Herald TranscriptFeb 25 2018, 9:48 AM

Harbormaster completed remote builds in B15258: Diff 39705.Feb 25 2018, 9:48 AM

There is a stage da violation

=>> Error: Filesystem touched during build:
extra: root/.cache

This revision now requires changes to proceed.Feb 26 2018, 7:03 AM

In D14503#304276, @tcberner wrote:
There is a stage da violation
=>> Error: Filesystem touched during build:
extra: root/.cache

Interesting. I didn't get this. Will see what might be causing it.

In D14503#304276, @tcberner wrote:
There is a stage da violation
=>> Error: Filesystem touched during build:
extra: root/.cache

@tcberner Are you building with testport?
In this case, Go ports are broken with testport.
It has to do that (I suspect) testport sets "HOME" environment variable.

In D14503#304276, @tcberner wrote:
There is a stage da violation
=>> Error: Filesystem touched during build:
extra: root/.cache

I can't understand why you are getting this error.
There is the algorithm in Go that chooses the cache directory. Environment variables GOCACHE, then XDG_DATA_HOME, then HOME.
Go ports don't do anything special for this because XDG_DATA_HOME is set during build.
I think your error might be intermittent.

mat added inline comments.Feb 27 2018, 3:35 PM

databases/usql/Makefile
36 ↗	(On Diff #39705)	Don't use `:=`, use `GH_ACCOUNT_DEFAULT` instead.

Harbormaster completed remote builds in B15308: Diff 39807.Feb 27 2018, 7:04 PM

yuri marked an inline comment as done.Feb 27 2018, 7:05 PM

Tobias,

This problem (with /root/.cache) is a general problem with many or all go ports. I just asked on ports@.
It builds fine here for me, though.
I think this makes it safe to commit, since there is nothing particularly wrong with this port. :)

Yuri

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2018, 9:40 AM

Closed by commit rP463561: New port: databases/usql: Universal command-line interface for SQL databases (authored by yuri). · Explain Why

This revision was automatically updated to reflect the committed changes.