Page MenuHomeFreeBSD
Differential D14456

First cut at fixing locking on da.
AbandonedPublic
Actions

Authored by imp on Feb 20 2018, 11:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 19 2024, 6:33 PM
Unknown Object (File)
Dec 29 2023, 12:58 AM
Unknown Object (File)
Dec 29 2023, 12:58 AM
Unknown Object (File)
Dec 29 2023, 12:58 AM
Unknown Object (File)
Dec 20 2023, 2:23 AM
Unknown Object (File)
Sep 13 2023, 4:04 AM
Unknown Object (File)
May 14 2023, 7:32 AM
Unknown Object (File)
Mar 16 2023, 11:19 AM
View All 15 Files
Subscribers
avg

Details

Reviewers
• hselasky

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15515
Build 15556: arc lint + arc unit

Event Timeline

imp created this revision.Feb 20 2018, 11:57 PM
Harbormaster completed remote builds in B15172: Diff 39544.Feb 20 2018, 11:57 PM
avg added a subscriber: avg.Feb 21 2018, 12:09 AM
• hselasky added a reviewer: • hselasky.Feb 21 2018, 9:01 PM
imp updated this revision to Diff 39592.Feb 21 2018, 11:28 PM

daerror should be called with the periph lock held, assert it rather
than take it.

• hselasky accepted this revision.Feb 25 2018, 12:24 PM

Test OK. No panic seen.

This revision is now accepted and ready to land.Feb 25 2018, 12:24 PM
• hselasky added a comment.Mar 7 2018, 9:23 PM

Ping - any update on this?

imp added a comment.Mar 7 2018, 9:57 PM

I have the hardware, finally, to try to reproduce this. I should be able to try later today.

imp updated this revision to Diff 40056.Mar 7 2018, 11:11 PM

Fixes

This revision now requires review to proceed.Mar 7 2018, 11:11 PM
Harbormaster completed remote builds in B15422: Diff 40056.Mar 7 2018, 11:11 PM
imp added a comment.Mar 7 2018, 11:11 PM

updated... I can't get this one to fail, but I couldn't get it to fail before.... Can you test?

• hselasky added a comment.Mar 9 2018, 8:42 AM

I cannot reproduce the panic with this patch.

imp updated this revision to Diff 40194.Mar 12 2018, 2:38 PM

Add lock around TUR stuff in response to a AEN

Harbormaster completed remote builds in B15515: Diff 40194.Mar 12 2018, 2:38 PM
• hselasky added a comment.Mar 17 2018, 6:13 PM

Ping - any news?

imp added a comment.Mar 17 2018, 7:12 PM
In D14456#309460, @hselasky wrote:

Ping - any news?

This was committed, but the code review wasn't closed, it seems....
commit 46e5edc20664bd3192e0a80a7fcaf21b1d674993
Author: imp <imp@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Date: Mon Mar 12 15:17:16 2018 +0000

Tighten up periph lock to avoid some races

Make sure the periph lock is held around rmw access to softc data,
espeically flags, including work flags in iosched.
Add asserts for the periph lock where it should be held.

PR: 226510
Sponsored by: Netflix
Differential Review: https://reviews.freebsd.org/D14456


git-svn-id: svn+ssh://svn.freebsd.org/base/head@330796 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
imp abandoned this revision.Mar 17 2018, 7:13 PM

This has been committed.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
35 lines

Diff 40194

View Options

sys/cam/scsi/scsi_da.c

Loading...