Page MenuHomeFreeBSD
Differential D1445

Add a note about what cannot go into MASTER_SITES.
ClosedPublic
Actions

Authored by mat on Jan 6 2015, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 1:16 AM
Unknown Object (File)
Nov 28 2024, 4:25 AM
Unknown Object (File)
Nov 23 2024, 6:42 PM
Unknown Object (File)
Nov 23 2024, 8:59 AM
Unknown Object (File)
Nov 21 2024, 8:27 PM
Unknown Object (File)
Nov 21 2024, 6:26 AM
Unknown Object (File)
Nov 20 2024, 10:42 PM
Unknown Object (File)
Nov 20 2024, 9:00 AM
View All 93 Files
Subscribers
ak
bcr
bdrewery
erwin
wblock
portmgr

Details

Reviewers
bcr
Group Reviewers
Doc Committers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mat updated this revision to Diff 3013.Jan 6 2015, 4:20 PM
mat retitled this revision from to Add a note about what cannot go into MASTER_SITES..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: Doc Committers.
mat added a subscriber: portmgr.
mat updated this revision to Diff 3014.Jan 6 2015, 4:34 PM

Add a bit about meta-ports.

bcr accepted this revision.Jan 6 2015, 4:36 PM
bcr added a reviewer: bcr.
bcr added a subscriber: bcr.

Looks good!

This revision is now accepted and ready to land.Jan 6 2015, 4:36 PM
ak added a subscriber: ak.Jan 6 2015, 4:51 PM
ak added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1638

IMHO, it's a little too vague, why can't MASTER_SITES points to webarchive.org or any other permanent archive ?

1640

Hmm. In some cases ports other than meta-ports can have MASTER_SITES left blank, like https://svnweb.freebsd.org/ports/head/www/googlebook_dl/Makefile?annotate=354597#l7

bdrewery added a subscriber: bdrewery.Jan 6 2015, 4:51 PM
bdrewery added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1636

USE_GITHUB is another exception.

mat updated this revision to Diff 3015.Jan 6 2015, 4:58 PM
mat edited edge metadata.

Reword the last sentence.

This revision now requires review to proceed.Jan 6 2015, 4:58 PM
bcr added inline comments.Jan 6 2015, 5:02 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1640

I would make that two sentences, it makes the sentences easier to read and understand:

  1. The only exception to this rule is ports that do not have any distribution files.
  2. For example, ...
erwin added a subscriber: erwin.Jan 6 2015, 5:21 PM

Looks good

wblock added a subscriber: wblock.Jan 7 2015, 1:24 AM
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1640

Agreed on both. For the second sentence:

For example, meta-ports do not have any distribution files, so <varname>MASTER_SITES</varname> does not need to be set.

mat added inline comments.Jan 7 2015, 10:45 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1638

Mmmm, because that's our policy.

mat updated this revision to Diff 3029.Jan 7 2015, 10:46 AM
mat edited edge metadata.

Update.

bcr accepted this revision.Jan 7 2015, 10:57 AM
bcr edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2015, 10:57 AM
mat closed this revision.Jan 7 2015, 11:09 AM

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
makefiles/
11 lines

Diff 3029

View Options

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml

Loading...