Page MenuHomeFreeBSD

libsa: Add MAXWAIT to net for establishing max total timeout
ClosedPublic

Authored by kevans on Feb 15 2018, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 7:09 AM
Unknown Object (File)
Sep 28 2024, 2:55 PM
Unknown Object (File)
Sep 28 2024, 10:44 AM
Unknown Object (File)
Sep 28 2024, 9:09 AM
Unknown Object (File)
Sep 18 2024, 4:38 AM
Unknown Object (File)
Sep 5 2024, 5:01 AM
Unknown Object (File)
Aug 30 2024, 1:46 PM
Unknown Object (File)
Aug 30 2024, 11:35 AM
Subscribers

Details

Summary

Current timeout behavior is to progress in timeout values from MINTMO to MAXTMO exponentially before finally timing out. This results in a fairly long time before operations finally timeout, which may not be ideal for some use-cases.

Add MAXWAIT that may be configured along with MINTMO/MAXTMO. If we attempt to start our send/recv cycle over again but MAXWAIT > 0 and MAXWAIT seconds have already passed, then go ahead and timeout.

This is intended for those that just want to say "timeout after 180 seconds" rather than calculate and tweak MINTMO/MAXTMO to get their desired timeout. The default is 0, or "progress from MINTMO to MAXTMO with no exception."

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbruno requested changes to this revision.Feb 15 2018, 9:53 PM
sbruno added a subscriber: sbruno.

Hmmm ... I'm up to five minutes waiting for a timeout here and I don't even see the twiddle moving.

This revision now requires changes to proceed.Feb 15 2018, 9:53 PM

After *READING* the review, I tested with a MAXWAIT of 20 and this works as advertised.

shipit

This revision is now accepted and ready to land.Feb 15 2018, 10:08 PM

looks good to me, but I've not deeply studied the network code to know for sure it's totally cool.

This revision was automatically updated to reflect the committed changes.