Page MenuHomeFreeBSD
Differential D14315

Fix -Wunused-variable warning in bmake without USE_FILEMON
AbandonedPublic
Actions

Authored by arichardson on Feb 11 2018, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 7:41 PM
Unknown Object (File)
Wed, Apr 15, 8:59 AM
Unknown Object (File)
Thu, Apr 9, 1:37 AM
Unknown Object (File)
Thu, Apr 9, 1:20 AM
Unknown Object (File)
Mar 16 2026, 4:00 AM
Unknown Object (File)
Mar 14 2026, 10:25 AM
Unknown Object (File)
Mar 13 2026, 8:13 AM
Unknown Object (File)
Mar 12 2026, 8:37 PM
View All 64 Files
Subscribers
None

Details

Reviewers
sjg
imp
jhb
Summary

This happens for example when building FreeBSD on MacOS since the check
in the Makefile will determine that filemon is not available. I am not
sure how to fix the check to be for the target system rather than the
host so for now I just added a TODO comment there.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14953
Build 15065: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 11 2018, 10:57 AM
Harbormaster completed remote builds in B14953: Diff 39172.Feb 11 2018, 10:57 AM
imp accepted this revision.Feb 11 2018, 5:54 PM
imp added inline comments.
usr.bin/bmake/Makefile
96–97

I wonder why we don't just always build this... The make code appears to cope with being told to use filemon, but /dev/filemon not opening.

This revision is now accepted and ready to land.Feb 11 2018, 5:54 PM
sjg added inline comments.Feb 13 2018, 7:40 PM
usr.bin/bmake/Makefile
96–97

This will be fixed with next import

arichardson abandoned this revision.Mar 12 2018, 9:51 AM

Fixed in rS330260

Revision Contents
Changeset List

PathSize
contrib/
bmake/
2 lines
usr.bin/
bmake/
4 lines

Diff 39172

View Options

contrib/bmake/meta.c

Loading...
View Options

usr.bin/bmake/Makefile

Loading...