Differential D14315

Fix -Wunused-variable warning in bmake without USE_FILEMON
AbandonedPublic
Actions

Authored by arichardson on Feb 11 2018, 10:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 11 2024, 11:27 PM

	Unknown Object (File)
	Jul 14 2023, 9:08 AM

	Unknown Object (File)
	Jun 3 2023, 1:42 AM

	Unknown Object (File)
	May 14 2023, 6:20 AM

Subscribers

None

Details

Reviewers

sjg
imp
jhb

Summary

This happens for example when building FreeBSD on MacOS since the check
in the Makefile will determine that filemon is not available. I am not
sure how to fix the check to be for the target system rather than the
host so for now I just added a TODO comment there.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14953
Build 15065: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 11 2018, 10:57 AM

Harbormaster completed remote builds in B14953: Diff 39172.Feb 11 2018, 10:57 AM

imp accepted this revision.Feb 11 2018, 5:54 PM

imp added inline comments.

usr.bin/bmake/Makefile
96–97	I wonder why we don't just always build this... The make code appears to cope with being told to use filemon, but /dev/filemon not opening.

This revision is now accepted and ready to land.Feb 11 2018, 5:54 PM

sjg added inline comments.Feb 13 2018, 7:40 PM

usr.bin/bmake/Makefile
96–97	This will be fixed with next import

Fixed in rS330260

Revision Contents
Changeset List

Path

Size

contrib/

bmake/

2 lines

usr.bin/

bmake/

4 lines

Diff 39172

contrib/bmake/meta.c

Loading...

usr.bin/bmake/Makefile

Loading...