Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.

[brooks]

Summary

This pattern is more common and easier to understand.

[rmacklem]

Looks ok to me, although, since I know nothing about the interface,
I've taken myself off the review.

[jhb]

sys/nlm/nlm_prot_impl.c

2404 ↗

(On Diff #39019)

I think you should actually do the nlm_uninit in MOD_UNLOAD case (modules get MOD_UNLOAD invoked if MOD_LOAD fails). It's fine to have that still fallthrough though.

[brooks]

• Let MOD_UNLOAD handle the failure case.