Paths

Table of Contentst

Differential D14231

Avoid find -s, use find | sort instead.
ClosedPublic
Actions

Authored by imp on Feb 6 2018, 10:09 PM.

Tags

None

Referenced Files

	F105783435: D14231.diff
	Fri, Dec 20, 3:40 PM

	Unknown Object (File)
	Sun, Dec 1, 10:13 PM

	Unknown Object (File)
	Sun, Dec 1, 10:13 PM

	Unknown Object (File)
	Sun, Dec 1, 10:13 PM

	Unknown Object (File)
	Sun, Dec 1, 10:12 PM

	Unknown Object (File)
	Sun, Dec 1, 10:12 PM

	Unknown Object (File)
	Sun, Dec 1, 9:29 PM

	Unknown Object (File)
	Nov 16 2024, 12:52 PM

View All 90 Files

Subscribers

Details

Reviewers

rpokala
emaste

Commits

rS328958: Avoid find -s, use find | sort instead.

Summary

find -s was introduced to make the metalog more
deterministic. However, find -s is not portable. find | sort is
portable and accomplishes the same goals, even if it isn't
pedantically the same. TZS is the same before / after the change so
any fussy differences between the two are moot and there won't be
METALOG churn across this change.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14826
Build 14943: arc lint + arc unit

Event Timeline

imp created this revision.Feb 6 2018, 10:09 PM

Harbormaster completed remote builds in B14823: Diff 38975.Feb 6 2018, 10:09 PM

rpokala accepted this revision.Feb 6 2018, 10:12 PM

This revision is now accepted and ready to land.Feb 6 2018, 10:12 PM

Might be wroth adding a comment that find -s is not portable, to discourage someone from changing it back to remove the extra exec as an optimization.

env LC_ALL=C sort, for great justice

This revision now requires review to proceed.Feb 6 2018, 10:30 PM

Harbormaster completed remote builds in B14824: Diff 38976.Feb 6 2018, 10:30 PM

LGTM although I still think a comment is warranted

This revision is now accepted and ready to land.Feb 6 2018, 10:43 PM

Overlooked emaste's comment suggestion, which I like...

This revision now requires review to proceed.Feb 6 2018, 11:08 PM

Harbormaster completed remote builds in B14826: Diff 38979.Feb 6 2018, 11:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2018, 11:12 PM

Closed by commit rS328958: Avoid find -s, use find | sort instead. (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

zoneinfo/

7 lines

Diff 38979

share/zoneinfo/Makefile

Loading...