Page MenuHomeFreeBSD
Differential D14231

Avoid find -s, use find | sort instead.
ClosedPublic
Actions

Authored by imp on Feb 6 2018, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 1:07 PM
Unknown Object (File)
Tue, Sep 30, 3:18 AM
Unknown Object (File)
Thu, Sep 25, 11:19 PM
Unknown Object (File)
Sep 1 2025, 9:59 PM
Unknown Object (File)
Aug 5 2025, 6:47 PM
Unknown Object (File)
Jul 14 2025, 9:39 AM
Unknown Object (File)
Jul 14 2025, 8:38 AM
Unknown Object (File)
Jul 12 2025, 2:36 PM
View All Files
Subscribers
emaste

Details

Reviewers
rpokala
emaste
Commits
rS328958: Avoid find -s, use find | sort instead.
Summary

find -s was introduced to make the metalog more
deterministic. However, find -s is not portable. find | sort is
portable and accomplishes the same goals, even if it isn't
pedantically the same. TZS is the same before / after the change so
any fussy differences between the two are moot and there won't be
METALOG churn across this change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Feb 6 2018, 10:09 PM
Harbormaster completed remote builds in B14823: Diff 38975.Feb 6 2018, 10:09 PM
rpokala accepted this revision.Feb 6 2018, 10:12 PM
This revision is now accepted and ready to land.Feb 6 2018, 10:12 PM
emaste added a subscriber: emaste.Feb 6 2018, 10:17 PM

Might be wroth adding a comment that find -s is not portable, to discourage someone from changing it back to remove the extra exec as an optimization.

imp updated this revision to Diff 38976.Feb 6 2018, 10:30 PM

env LC_ALL=C sort, for great justice

This revision now requires review to proceed.Feb 6 2018, 10:30 PM
Harbormaster completed remote builds in B14824: Diff 38976.Feb 6 2018, 10:30 PM
emaste accepted this revision.Feb 6 2018, 10:43 PM

LGTM although I still think a comment is warranted

This revision is now accepted and ready to land.Feb 6 2018, 10:43 PM
imp updated this revision to Diff 38979.Feb 6 2018, 11:08 PM

Overlooked emaste's comment suggestion, which I like...

This revision now requires review to proceed.Feb 6 2018, 11:08 PM
Harbormaster completed remote builds in B14826: Diff 38979.Feb 6 2018, 11:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2018, 11:12 PM
Closed by commit rS328958: Avoid find -s, use find | sort instead. (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
share/
zoneinfo/
7 lines

Diff 38980

View Options

head/share/zoneinfo/Makefile

Loading...