Page MenuHomeFreeBSD

devel/p4 devel/p4api: cache distfiles in LOCAL
ClosedPublic

Authored by asomers on Feb 5 2018, 9:16 PM.
Tags
None
Referenced Files
F85444663: D14211.diff
Thu, Jun 6, 4:37 AM
Unknown Object (File)
Tue, May 21, 12:47 AM
Unknown Object (File)
Tue, May 21, 12:46 AM
Unknown Object (File)
Tue, May 21, 12:46 AM
Unknown Object (File)
Fri, May 17, 8:30 AM
Unknown Object (File)
Apr 19 2024, 2:35 PM
Unknown Object (File)
Apr 19 2024, 8:08 AM
Unknown Object (File)
Apr 5 2024, 9:07 PM
Subscribers

Details

Summary

devel/p4 devel/p4api: cache distfiles in LOCAL

Perforce unhelpfully rebuilds their distfiles every few hours, changing the
archived files' timestamps in the process. This obviously changes their
checksums. Work around the issue by caching local copies of the distfiles and
using those for the checksums.

Also, set a sane DIST_SUBDIR since the distfiles are ambiguously named.

Also, take over maintainership from gordon.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14797
Build 14916: arc lint + arc unit

Event Timeline

Would it be better off to just not do checksumming for this and use the source as is?

Would it be better off to just not do checksumming for this and use the source as is?

@mat requested that I use a local mirror rather than disable checksumming. And from a security perspective, that's certainly better. I also tried adding a post-patch step that would unzip the distfile, make the timestamps uniform, then rezip it. However, I ran into problems with that approach. Chiefly, I couldn't figure out how to stop that step from running when it shouldn't. For example, it would run during the extract phase, which breaks poudriere because /portdistfiles is mounted read-only during that phase.

Would it be better off to just not do checksumming for this and use the source as is?

No.

Okay, based on that, looks good to me.

This revision is now accepted and ready to land.Feb 6 2018, 12:31 AM
This revision was automatically updated to reflect the committed changes.