Page MenuHomeFreeBSD

devel/p4 devel/p4api: cache distfiles in LOCAL
ClosedPublic

Authored by asomers on Feb 5 2018, 9:16 PM.
Tags
None
Referenced Files
F104054093: D14211.id38905.diff
Mon, Dec 2, 10:08 PM
Unknown Object (File)
Sun, Nov 24, 8:44 AM
Unknown Object (File)
Thu, Nov 21, 5:38 PM
Unknown Object (File)
Thu, Nov 21, 3:17 PM
Unknown Object (File)
Sun, Nov 10, 3:02 PM
Unknown Object (File)
Nov 1 2024, 2:32 PM
Unknown Object (File)
Oct 4 2024, 2:37 PM
Unknown Object (File)
Oct 2 2024, 7:23 AM
Subscribers

Details

Summary

devel/p4 devel/p4api: cache distfiles in LOCAL

Perforce unhelpfully rebuilds their distfiles every few hours, changing the
archived files' timestamps in the process. This obviously changes their
checksums. Work around the issue by caching local copies of the distfiles and
using those for the checksums.

Also, set a sane DIST_SUBDIR since the distfiles are ambiguously named.

Also, take over maintainership from gordon.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Would it be better off to just not do checksumming for this and use the source as is?

Would it be better off to just not do checksumming for this and use the source as is?

@mat requested that I use a local mirror rather than disable checksumming. And from a security perspective, that's certainly better. I also tried adding a post-patch step that would unzip the distfile, make the timestamps uniform, then rezip it. However, I ran into problems with that approach. Chiefly, I couldn't figure out how to stop that step from running when it shouldn't. For example, it would run during the extract phase, which breaks poudriere because /portdistfiles is mounted read-only during that phase.

Would it be better off to just not do checksumming for this and use the source as is?

No.

Okay, based on that, looks good to me.

This revision is now accepted and ready to land.Feb 6 2018, 12:31 AM
This revision was automatically updated to reflect the committed changes.