Fix "zpool add" crash when a replacing vdev has a spare child
ClosedPublic
Actions

Authored by asomers on Jan 30 2018, 9:49 PM.

Tags

None

Referenced Files

	F169149372: D14138.diff
	Mon, Aug 31, 2:37 PM

	F169142900: D14138.id.diff
	Mon, Aug 31, 2:02 PM

	Unknown Object (File)
	Sun, Aug 30, 10:05 AM

	Unknown Object (File)
	Fri, Aug 28, 2:48 AM

	Unknown Object (File)
	Tue, Aug 25, 3:40 PM

	Unknown Object (File)
	Tue, Aug 25, 7:06 AM

	Unknown Object (File)
	Tue, Aug 25, 7:04 AM

	Unknown Object (File)
	Tue, Aug 25, 6:33 AM

View All Files

Subscribers

imp

Details

Reviewers

avg

Commits

rS330735: MFC r329067:
rS330728: MFC r329067:
rS329067: Fix "zpool add" crash when a replacing vdev has a spare child

Summary

Fix "zpool add" crash when a replacing vdev has a spare child

Fix an assertion in zpool that causes a crash when running any "zpool add"
command on a spare that contains a replacing vdev with a spare child.

PR: 225546

Test Plan

Added zpool_add_010_pos to the ZFS test suite

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jan 30 2018, 9:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2018, 9:49 PM

Harbormaster completed remote builds in B14684: Diff 38690.Jan 30 2018, 9:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 4:09 PM

Closed by commit rS329067: Fix "zpool add" crash when a replacing vdev has a spare child (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

cmd/

zpool/

zpool_vdev.c

15 lines

Diff 39090

View Options

head/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c

Fix "zpool add" crash when a replacing vdev has a spare childClosedPublicActions