After r328426, g_label depends on FFS bits to read UFS
superblock. This change makes it depend on the required minimum
FFS bits and unbreaks kernels without FFS option.
Details
Details
compile without FFS
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/conf/files | ||
|---|---|---|
| 4818–4819 ↗ | (On Diff #38579) | I was expecting to see that geom_label was now dependent on ffs. This seems to have the dependency backwards... Why did you do it this way? |
| sys/conf/files | ||
|---|---|---|
| 4818–4819 ↗ | (On Diff #38579) | The intention is "if either ffs or geom_label is selected, grab in ufs/ffs/ffs_subr.c and ffs_tables.c", was the syntax wrong here? |
Comment Actions
I agree that the dependency needs to be added though I am not sure precisely how it should be done. I suggest added kib@ as a reviewer because he is up-to-date with the way that these sorts of dependencies should be indicated.
Comment Actions
For static compilation, this is perhaps fine.
But for modules, I dislike the idea of making g_label depended on the ufs.ko. I would prefer the corresponding code to be included in g_label module.