Page MenuHomeFreeBSD
Differential D14001

x11-themes/sddm-freebsd-black-theme: improving the port.
ClosedPublic
Actions

Authored by rigoletto on Jan 20 2018, 8:28 PM.
Tags
None
Referenced Files
F81698766: D14001.diff
Sat, Apr 20, 3:21 AM
Unknown Object (File)
Mar 9 2024, 3:03 PM
Unknown Object (File)
Mar 9 2024, 3:03 PM
Unknown Object (File)
Mar 9 2024, 3:03 PM
Unknown Object (File)
Mar 9 2024, 3:03 PM
Unknown Object (File)
Mar 9 2024, 2:13 PM
Unknown Object (File)
Jan 2 2024, 10:54 PM
Unknown Object (File)
Nov 4 2023, 6:49 AM
View All 27 Files
Subscribers
decke
mat
Contributor Reviewers (ports)

Details

Reviewers
adridg
decke
Commits
rP461336: - Add missing dependency on montserrat font
Summary
  • switch to DISTVERSION
  • add an OPTION of the default font

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14884
Build 14996: arc lint + arc unit

Event Timeline

rigoletto created this revision.Jan 20 2018, 8:28 PM
Harbormaster completed remote builds in B14505: Diff 38259.Jan 20 2018, 8:28 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptJan 20 2018, 8:28 PM
rigoletto added a reviewer: adridg.Jan 20 2018, 10:07 PM
adridg added inline comments.Feb 8 2018, 3:32 PM
x11-themes/sddm-freebsd-black-theme/Makefile
23

Indentation issues? (Sorry, hard to tell in phab's web interface)

26

Does this need to be an option? Why not make it required? Same applies to your other port, I don't understand why a font (presumably required to make the theme look "right") is an optional dependency.

adridg mentioned this in D14002: x11-themes/slim-freebsd-black-theme: New Port..Feb 8 2018, 3:33 PM
decke accepted this revision.Feb 8 2018, 4:00 PM
decke added a subscriber: decke.
This comment was removed by decke.
This revision is now accepted and ready to land.Feb 8 2018, 4:00 PM
decke added a comment.Feb 8 2018, 4:04 PM

Sorry that was the wrong Phabricator ticket. It was meant for D14002.

decke added a comment.Feb 8 2018, 4:16 PM

I'd propose the following patch:

D14001-1.diff582 BDownload

rigoletto updated this revision to Diff 39063.Feb 8 2018, 8:26 PM
rigoletto marked 2 inline comments as done.

Done. :)

This revision now requires review to proceed.Feb 8 2018, 8:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 8:29 PM
Closed by commit rP461336: - Add missing dependency on montserrat font (authored by decke). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11-themes/
sddm-freebsd-black-theme/
5 lines

Diff 39063

View Options

x11-themes/sddm-freebsd-black-theme/Makefile

Loading...