Remove extra copy of bootinfo.c. It's a bit rotted copy of the one in efi/loader.
ClosedPublic
Actions

Authored by imp on Jan 19 2018, 4:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 23 2023, 9:31 PM

	Unknown Object (File)
	Dec 20 2023, 3:52 AM

	Unknown Object (File)
	Dec 19 2023, 10:31 PM

	Unknown Object (File)
	Nov 15 2023, 10:09 AM

	Unknown Object (File)
	Nov 2 2023, 1:20 AM

	Unknown Object (File)
	Oct 14 2023, 9:11 AM

	Unknown Object (File)
	Sep 23 2023, 3:50 AM

	Unknown Object (File)
	Sep 5 2023, 5:17 PM

View All 16 Files

Subscribers

bcran

dab

Details

Reviewers

emaste

Commits

rGcec2b3064525: Remove extra copy of bootinfo.c. It's a bit rotted copy of the one in

Summary

This appears to be a duplicate copy that was hacked, but has since bit rotted. We should kill it and if there's anything here that actually works, we should move it into the one in loader/bootinfo.c.

And then we should merge it with all the other metadata stuff. Too many cut and paste copies of that code!

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14482
Build 14624: arc lint + arc unit

Event Timeline

imp created this revision.Jan 19 2018, 4:57 PM

imp edited the summary of this revision. (Show Details)Jan 19 2018, 4:58 PM

imp added a reviewer: emaste.

Sounds good to me. When bringing back i386 EFI we should start from (and end with) a shared bootinfo.c

This revision is now accepted and ready to land.Jan 19 2018, 5:25 PM

imp closed this revision.Jul 9 2021, 8:20 PM

Herald added subscribers: dab, bcran. · View Herald TranscriptJul 9 2021, 8:20 PM

emaste added a commit: rGcec2b3064525: Remove extra copy of bootinfo.c. It's a bit rotted copy of the one in.Jul 16 2021, 2:10 AM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

i386/

bootinfo.c

Diff 38210

View Options

stand/efi/loader/arch/i386/bootinfo.c

Remove extra copy of bootinfo.c. It's a bit rotted copy of the one in efi/loader.ClosedPublicActions