Move per-operation data out of the csession structure.
ClosedPublic
Actions

Authored by jhb on Jan 16 2018, 12:59 AM.

Details

Reviewers

kib
jmg

Commits

rS328453: Move per-operation data out of the csession structure.

Summary

Create a struct cryptop_data which contains state needed for a single
symmetric crypto operation and move that state out of the session. This
closes a race with the CRYPTO_F_DONE flag that can result in use after
free.

PR: 218597

Test Plan

cryptocheck and cryptotest.py against cryptosoft0, ccr0, and aesni0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 16 2018, 12:59 AM

Harbormaster completed remote builds in B14405: Diff 38021.Jan 16 2018, 12:59 AM

kib accepted this revision.Jan 17 2018, 9:29 AM

kib added inline comments.

sys/opencrypto/cryptodev.c
1094 ↗	(On Diff #38021)	What is the purpose of this locking ?

This revision is now accepted and ready to land.Jan 17 2018, 9:29 AM

jhb added inline comments.Jan 17 2018, 10:41 PM

sys/opencrypto/cryptodev.c
1094 ↗	(On Diff #38021)	Just to avoid losing wakeups() with the loop at line 1050.

Closed by commit rS328453: Move per-operation data out of the csession structure. (authored by jhb). · Explain WhyJan 26 2018, 11:22 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: jmg. · View Herald TranscriptJan 26 2018, 11:22 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

cryptodev.c

160 lines

Diff 38504

View Options

head/sys/opencrypto/cryptodev.c

Move per-operation data out of the csession structure.ClosedPublicActions