Page MenuHomeFreeBSD

Split crp_buf into a union.
ClosedPublic

Authored by jhb on Jan 16 2018, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 10:44 AM
Unknown Object (File)
Sun, Nov 9, 8:10 AM
Unknown Object (File)
Thu, Nov 6, 4:09 AM
Unknown Object (File)
Sun, Oct 26, 6:21 AM
Unknown Object (File)
Thu, Oct 23, 4:00 AM
Unknown Object (File)
Wed, Oct 22, 8:04 PM
Unknown Object (File)
Wed, Oct 22, 8:04 PM
Unknown Object (File)
Wed, Oct 22, 9:50 AM
Subscribers

Details

Summary

This adds explicit crp_mbuf and crp_uio pointers of the right type to
replace casts of crp_buf. This does not sweep through changing existing
code, but new code should use the correct fields instead of casts.

Test Plan
  • tested with cryptocheck and the in-tree cryptotest tests against cryptosoft, aesni0, and ccr0

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

As a note, anonymous union member is only in C11, for C99 this is a gnu extension.

This revision is now accepted and ready to land.Jan 16 2018, 3:23 PM

Yes, though we already use anonymous unions in the tree now (e.g. struct mbuf uses them).

This revision was automatically updated to reflect the committed changes.