Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 5:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 17, 3:30 AM

	Unknown Object (File)
	Mon, Mar 10, 5:58 PM

	Unknown Object (File)
	Feb 17 2025, 3:57 AM

	Unknown Object (File)
	Feb 11 2025, 10:06 PM

	Unknown Object (File)
	Feb 8 2025, 4:58 PM

	Unknown Object (File)
	Feb 8 2025, 9:36 AM

	Unknown Object (File)
	Jan 25 2025, 7:28 PM

	Unknown Object (File)
	Jan 24 2025, 6:54 PM

View All 59 Files

Subscribers

None

Details

Reviewers

andrew
tsoome

Commits

rS328030: Check the return value from utf8_to_ucs2 instead of whether or not uv

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 15 2018, 5:03 PM

Harbormaster completed remote builds in B14385: Diff 37976.Jan 15 2018, 5:03 PM

imp added reviewers: andrew, tsoome.Jan 15 2018, 5:03 PM

tsoome added inline comments.Jan 15 2018, 7:58 PM

stand/efi/boot1/boot1.c
105 ↗	(On Diff #37976)	If we check the return value below, we do not need to set NULL here, except if the compiler will trigger may be used uninitialized warning...

imp added inline comments.Jan 15 2018, 10:09 PM

stand/efi/boot1/boot1.c
105 ↗	(On Diff #37976)	We do, because we want utf8_to_ucs2 to allocate space.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2018, 10:17 PM

Closed by commit rS328030: Check the return value from utf8_to_ucs2 instead of whether or not uv (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

efi/

boot1/

boot1.c

3 lines

Diff 38001

View Options

head/stand/efi/boot1/boot1.c

Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.ClosedPublicActions