Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 5:03 PM.

Details

Reviewers

andrew
tsoome

Commits

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

stand/efi/boot1/boot1.c
105 ↗	(On Diff #37976)	If we check the return value below, we do not need to set NULL here, except if the compiler will trigger may be used uninitialized warning...

stand/efi/boot1/boot1.c
105 ↗	(On Diff #37976)	We do, because we want utf8_to_ucs2 to allocate space.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2018, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

head/

stand/

efi/

boot1/

3 lines