Page MenuHomeFreeBSD
Differential D13880

www/node can be built by gcc now
ClosedPublic
Actions

Authored by jhibbits on Jan 12 2018, 2:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 11:18 AM
Unknown Object (File)
Mar 13 2024, 8:09 PM
Unknown Object (File)
Jan 21 2024, 4:47 AM
Unknown Object (File)
Jan 14 2024, 5:37 PM
Unknown Object (File)
Nov 27 2023, 6:45 PM
Unknown Object (File)
Nov 8 2023, 1:36 AM
Unknown Object (File)
Oct 25 2023, 12:20 PM
Unknown Object (File)
Oct 25 2023, 12:20 PM
View All 19 Files
Subscribers
linimon
mat

Details

Reviewers
bhughes
Commits
rP461971: Mark www/node as buildable by powerpc64
Summary

As of node 9.3.0, a bug was fixed preventing builds with gcc. Don't prevent gcc
from building it now.

Test Plan

Built for powerpc64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14325
Build 14483: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jan 12 2018, 2:30 AM
Harbormaster completed remote builds in B14325: Diff 37851.Jan 12 2018, 2:30 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 12 2018, 2:30 AM
bhughes added a comment.Jan 12 2018, 7:37 AM

What about MIPS?

jhibbits added a comment.Jan 12 2018, 3:45 PM
In D13880#290896, @bhughes wrote:

What about MIPS?

I don't see anything in the node source that's platform specific. Granted, I haven't test-compiled for mips, so it might be broken, but gcc is no longer the limiting factor (I only have powerpc machines).

jhibbits added a comment.Jan 12 2018, 4:01 PM

Testing further, on my powerpcspe machine, It looks like node.js needs a little work for the configure script to build on powerpc, powerpcspe, and possibly mips. So I'll just add powerpc64 to the ONLY_FOR_ARCHS line instead.

jhibbits updated this revision to Diff 39331.Feb 15 2018, 3:28 AM

Only add powerpc64 to node Makefile. powerpc and powerpcspe still need work,
and mips is unknown.

bhughes accepted this revision.Feb 15 2018, 7:18 AM

LGTM

This revision is now accepted and ready to land.Feb 15 2018, 7:18 AM
Closed by commit rP461971: Mark www/node as buildable by powerpc64 (authored by jhibbits). · Explain WhyFeb 16 2018, 3:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
www/
node/
2 lines

Diff 37851

View Options

www/node/Makefile

Loading...