Page MenuHomeFreeBSD

www/node can be built by gcc now
ClosedPublic

Authored by jhibbits on Jan 12 2018, 2:30 AM.

Details

Summary

As of node 9.3.0, a bug was fixed preventing builds with gcc. Don't prevent gcc
from building it now.

Test Plan

Built for powerpc64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Jan 12 2018, 2:30 AM

What about MIPS?

What about MIPS?

I don't see anything in the node source that's platform specific. Granted, I haven't test-compiled for mips, so it might be broken, but gcc is no longer the limiting factor (I only have powerpc machines).

Testing further, on my powerpcspe machine, It looks like node.js needs a little work for the configure script to build on powerpc, powerpcspe, and possibly mips. So I'll just add powerpc64 to the ONLY_FOR_ARCHS line instead.

jhibbits updated this revision to Diff 39331.Feb 15 2018, 3:28 AM

Only add powerpc64 to node Makefile. powerpc and powerpcspe still need work,
and mips is unknown.

bhughes accepted this revision.Feb 15 2018, 7:18 AM

LGTM

This revision is now accepted and ready to land.Feb 15 2018, 7:18 AM
This revision was automatically updated to reflect the committed changes.