Differential D13880

www/node can be built by gcc now
ClosedPublic
Actions

Authored by jhibbits on Jan 12 2018, 2:30 AM.

Details

Reviewers

bhughes

Commits

rP461971: Mark www/node as buildable by powerpc64

Summary

As of node 9.3.0, a bug was fixed preventing builds with gcc. Don't prevent gcc
from building it now.

Test Plan

Built for powerpc64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 12 2018, 2:30 AM

Harbormaster completed remote builds in B14325: Diff 37851.Jan 12 2018, 2:30 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 12 2018, 2:30 AM

What about MIPS?

In D13880#290896, @bhughes wrote:

What about MIPS?

I don't see anything in the node source that's platform specific. Granted, I haven't test-compiled for mips, so it might be broken, but gcc is no longer the limiting factor (I only have powerpc machines).

Testing further, on my powerpcspe machine, It looks like node.js needs a little work for the configure script to build on powerpc, powerpcspe, and possibly mips. So I'll just add powerpc64 to the ONLY_FOR_ARCHS line instead.

Only add powerpc64 to node Makefile. powerpc and powerpcspe still need work,
and mips is unknown.

LGTM

This revision is now accepted and ready to land.Feb 15 2018, 7:18 AM

Closed by commit rP461971: Mark www/node as buildable by powerpc64 (authored by jhibbits). · Explain WhyFeb 16 2018, 3:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

www/

node/

Makefile

2 lines

Diff 39371

View Options

www/node can be built by gcc nowClosedPublicActions