Page MenuHomeFreeBSD
Differential D13847

Axe tmp_iv.
ClosedPublic
Actions

Authored by jhb on Jan 11 2018, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 1:05 PM
Unknown Object (File)
Mon, Sep 7, 10:31 AM
Unknown Object (File)
Fri, Sep 4, 6:44 PM
Unknown Object (File)
Fri, Sep 4, 7:57 AM
Unknown Object (File)
Thu, Sep 3, 10:22 PM
Unknown Object (File)
Thu, Sep 3, 10:22 PM
Unknown Object (File)
Thu, Sep 3, 4:44 PM
Unknown Object (File)
Thu, Sep 3, 2:40 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
jmg
Commits
rS327838: Axe tmp_iv from the cryptodev session structure.
Summary

Just copyin the IV into the crypto descriptor directly.

This avoids copying the IV twice for each operation.

Test Plan
  • have run my cryptocheck tool against this numerous times, but also requests from OpenSSL's engine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 11 2018, 12:25 AM
kib accepted this revision.Jan 11 2018, 11:13 AM

Does this mean that crd_iv potentially contains unknown data ? E.g. after the partial copy + fault.

Perhaps it is fine because the content of crd_iv is user-controlled anyway.

This revision is now accepted and ready to land.Jan 11 2018, 11:13 AM
jhb added a comment.Jan 11 2018, 5:48 PM

crd_iv is only used after the copyin() if it succeeds. It shouldn't have any different data as a result of this change once a request is submitted to the driver.

Closed by commit rS327838: Axe tmp_iv from the cryptodev session structure. (authored by jhb). · Explain WhyJan 11 2018, 6:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 11 2018, 6:07 PM

Revision Contents
Changeset List

PathSize
head/
sys/
opencrypto/
9 lines

Diff 37821

View Options

head/sys/opencrypto/cryptodev.c

Loading...