Just copyin the IV into the crypto descriptor directly.
This avoids copying the IV twice for each operation.
Details
Details
- Reviewers
kib jmg - Commits
- rS327838: Axe tmp_iv from the cryptodev session structure.
- have run my cryptocheck tool against this numerous times, but also requests from OpenSSL's engine
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Does this mean that crd_iv potentially contains unknown data ? E.g. after the partial copy + fault.
Perhaps it is fine because the content of crd_iv is user-controlled anyway.
Comment Actions
crd_iv is only used after the copyin() if it succeeds. It shouldn't have any different data as a result of this change once a request is submitted to the driver.