Page MenuHomeFreeBSD

Make use of mallocarray(9) in drm drivers.
ClosedPublic

Authored by pfg on Jan 10 2018, 8:40 PM.
Tags
None
Referenced Files
F106098495: D13835.diff
Wed, Dec 25, 9:16 AM
F106049686: D13835.id.diff
Tue, Dec 24, 12:29 PM
Unknown Object (File)
Sep 22 2024, 5:48 AM
Unknown Object (File)
Sep 18 2024, 11:33 AM
Unknown Object (File)
Sep 15 2024, 3:48 PM
Unknown Object (File)
Sep 11 2024, 4:37 PM
Unknown Object (File)
Sep 1 2024, 9:43 PM
Unknown Object (File)
Aug 30 2024, 3:16 AM
Subscribers

Details

Summary

These seem like easy cases where we can use mallocarray(9), however I am
unsure if doing such changes will increase the difficulty for future
merges.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14335
Build 14493: arc lint + arc unit

Event Timeline

Hi!

What is the benefit of using mallocarray() here?

Hi!

What is the benefit of using mallocarray() here?

TBH, I don't think there is any chance of an overflow with real hardware. Perhaps in a virtualized world there may be a chance to cause an overflow on anything or with specialized hardware (like the PS4 hackers did) but that's pretty extreme.
I am trying to keep the kernel consistent using mallocarray(9) where it can be used, but I am OK if you don't want this.

The code should be eaiser to read, but it will also make merging back the code to stable a nightmare.

This should be a minimal and more straightforward replacement.

Note that we now panic if there is an overflow.

This is small enough that shouldn't affect upstream merging (also the code is very FreeBSD-specific).
It also respects the general objective of the code.

This revision is now accepted and ready to land.Jan 22 2018, 2:35 AM

Yes, that's fine, the patch is small enough. Thank you!

This revision was automatically updated to reflect the committed changes.