Page MenuHomeFreeBSD
Differential D13804

Add support for GCC-based targets to luajit
ClosedPublic
Actions

Authored by jhibbits on Jan 9 2018, 4:49 AM.
Tags
None
Referenced Files
F108003827: D13804.id37708.diff
Mon, Jan 20, 10:17 AM
Unknown Object (File)
Dec 10 2024, 4:20 AM
Unknown Object (File)
Dec 10 2024, 4:17 AM
Unknown Object (File)
Dec 10 2024, 4:17 AM
Unknown Object (File)
Nov 5 2024, 7:41 AM
Unknown Object (File)
Oct 3 2024, 7:17 AM
Unknown Object (File)
Sep 5 2024, 10:19 PM
Unknown Object (File)
Sep 5 2024, 2:33 AM
View All 49 Files
Subscribers
linimon
mat

Details

Reviewers
osa
mat
Commits
rP458594: Add support for GCC-based targets to luajit
Summary

luajit requires CC to be passed on the command line, not via the Make
environment in order to override the Makefile. Pass it explicitly, and for GCC
targets (powerpc, mips, sparc64) explicitly use ports GCC.

Test Plan

Successfully built on powerpc. Does not build for powerpc64, though.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 9 2018, 4:49 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 9 2018, 4:49 AM
Harbormaster completed remote builds in B14207: Diff 37662.Jan 9 2018, 4:49 AM
mat added inline comments.Jan 9 2018, 1:11 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

ARCH is not defined before including b.p.options.m.

jhibbits added inline comments.Jan 9 2018, 2:59 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

Hm, now I'm wondering how my build completed successfully.

mat added inline comments.Jan 9 2018, 3:04 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

If you are cross-building, poudriere defines ARCH in make.conf or something, so it will work, but only when crossbuilding, it would break on amd64 for example :-)

jhibbits added inline comments.Jan 9 2018, 3:06 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

I just tested, by adding a ".info ${ARCH}" into that block, and it did print out "powerpc". Might ARCH be defined elsewhere, too, maybe implicitly?

jhibbits added inline comments.Jan 9 2018, 3:17 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

Aha, got it... yeah, crossbuilding to ppc32 on ppc64, and ARCH is defined in the make.conf. I guess I need to include b.p.pre.mk / b.p.post.mk?

mat added inline comments.Jan 9 2018, 3:19 PM
lang/luajit/Makefile
21–23 ↗(On Diff #37662)

No need to bring pre and post, simply include bsd.port.options.mk before the .if.

jhibbits updated this revision to Diff 37680.Jan 9 2018, 3:28 PM

Update given mat's feedback. Tested with powerpc and powerpc64

Harbormaster completed remote builds in B14218: Diff 37680.Jan 9 2018, 3:28 PM
mat added inline comments.Jan 9 2018, 3:34 PM
lang/luajit/Makefile
6 ↗(On Diff #37680)

You do not need to bump PORTREVISION, it does not change anything for the architectures where it already worked, and it did not previously exist in the new architectures.

17 ↗(On Diff #37680)

You do not need += here.

jhibbits added inline comments.Jan 9 2018, 3:38 PM
lang/luajit/Makefile
6 ↗(On Diff #37680)

This is an artifact of using two different ports trees for my work (poudriere, and commit). The real ports tree does have the PORTREVISION already, my 'commit' tree does not. Will update svn and repost the fixed diff with the MAKE_ARGS correction.

mat accepted this revision.Jan 9 2018, 3:41 PM
mat added inline comments.
lang/luajit/Makefile
6 ↗(On Diff #37680)

No need to re-update it, just commit it :-)

This revision is now accepted and ready to land.Jan 9 2018, 3:41 PM
Closed by commit rP458594: Add support for GCC-based targets to luajit (authored by jhibbits). · Explain WhyJan 10 2018, 3:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lang/
luajit/
9 lines

Diff 37708

View Options

head/lang/luajit/Makefile

Loading...