py-cffi upgrade to 1.11.2 {URGENT FIX}
ClosedPublic
Actions

Authored by yuri on Jan 4 2018, 10:53 AM.

Details

Reviewers

tcberner
adamw

Summary

An extra suffix .abi3 causes strip commands to fail for python36 flavor.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14123
Build 14297: arc lint + arc unit

Event Timeline

yuri created this revision.Jan 4 2018, 10:53 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 10:53 AM

Harbormaster completed remote builds in B14104: Diff 37503.Jan 4 2018, 10:53 AM

yuri retitled this revision from security/py-pynacl security/py-bcrypt devel/py-pygit2 databases/py-psycopg2cffi: Corrected shared library name that got the .abi3 suffix for python-36 and up after devel/py-cffi upgrade to 1.11.2 to security/py-pynacl security/py-bcrypt devel/py-pygit2 databases/py-psycopg2cffi: Corrected shared library names that got the .abi3 suffix for python-36 and up after devel/py-cffi upgrade to 1.11.2.Jan 4 2018, 10:56 AM

yuri retitled this revision from security/py-pynacl security/py-bcrypt devel/py-pygit2 databases/py-psycopg2cffi: Corrected shared library names that got the .abi3 suffix for python-36 and up after devel/py-cffi upgrade to 1.11.2 to security/py-pynacl security/py-bcrypt devel/py-pygit2 databases/py-psycopg2cffi: Corrected shared library names that got the .abi3 suffix for python-36 and up after devel/py-cffi upgrade to 1.11.2 {URGENT FIX}.Jan 4 2018, 11:43 AM

Why do you bump PORTREVISION?

In D13763#288078, @mat wrote:

Why do you bump PORTREVISION?

Because plists changed.
They changed when py-cffi was updated. This went unnoticed. That's why bumping now.

Oh, yes, ok, the cffi you updated without testing, right, forgot about it already.

In D13763#288092, @mat wrote:

Oh, yes, ok, the cffi you updated without testing, right, forgot about it already.

I tested it. But the tests didn't catch the problem.

OK. Looks good now.

This revision is now accepted and ready to land.Jan 4 2018, 7:24 PM

In D13763#288232, @tcberner wrote:

OK. Looks good now.

Tobias, I looked more. Some other dependent ports also install shared objects, therefore have their plist changed, but are also missing STRIP and therefore don't trigger an error.

I will expand the list of changes with similar updates for some more ports.

Expanded the list to 10 ports. Added STRIP_CMD where missing. Bumped where needed.
The remaining 5 of 15 dependencies don't install shared objects which filenames changed.

FYI, no test could catch these extra 6 ports. Their plists changed, but due to python's autoplist feature they wouldn't have been caught by rebuilding.

I verified that all of them build.

@tcberner Tobias, could you please approve this patch?

This revision now requires review to proceed.Jan 4 2018, 8:51 PM

adamw accepted this revision.Jan 5 2018, 1:59 PM

This revision is now accepted and ready to land.Jan 5 2018, 1:59 PM

yuri closed this revision.Jan 5 2018, 8:03 PM