chinese/ibus-pinyin: Fixed build with NLS=off
ClosedPublic

Authored by yuri on Tue, Jan 2, 7:37 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yuri created this revision.Tue, Jan 2, 7:37 AM
tcberner added inline comments.Tue, Jan 2, 8:19 AM
chinese/ibus-pinyin/Makefile
20 ↗(On Diff #37399)

so what is the point of having an NLS option, if you have to depend on gettext anyways?

yuri marked an inline comment as done.Tue, Jan 2, 8:35 AM
yuri added inline comments.
chinese/ibus-pinyin/Makefile
20 ↗(On Diff #37399)

It's a bug in GNU toolchain. It has files with double .in suffix (.in.in) that are processed by gettext unconditionally. The point of the NLS option is that translation files aren't installed when NLS=off. One way to handle this is to remove NLS and have it always on. But I would rather see the option that removes files.

yuri marked 2 inline comments as done.Tue, Jan 2, 8:35 AM
yuri added a comment.Tue, Jan 2, 8:46 AM

This port has been breaking with the blanked NLS=off rule. There is no way we can fix GNU toolchain. So there are two options: kill NLS altogether, or keep it being able to disable the installed files.
I have a preference for the latter choice. Is this perfect? Not at all. This will never be perfect. It's just a pragmatic choice.

There's nothing more to this matter. :-)

tcberner accepted this revision.Tue, Jan 9, 9:05 PM

Please double check with the maintainer that this change is what they accepted.

From my side it is fine (although I would rather have the option gone completely ^^).

This revision is now accepted and ready to land.Tue, Jan 9, 9:05 PM
yuri added a comment.Tue, Jan 9, 11:55 PM

Please double check with the maintainer that this change is what they accepted.

Yes, I am positive that this is what he accepted. :-)

This revision was automatically updated to reflect the committed changes.
mat added a comment.Wed, Jan 10, 2:43 PM

Adding all of gettext when NLS is disabled is most certainly bogus.

This should probably be:

NLS_USES=     gettext-runtime
NLS_USES_OFF= gettext-tools