Page MenuHomeFreeBSD

Convert the x86 RTC driver to use new validated BCD<->timespec conversions
AbandonedPublic

Authored by ian on Jan 1 2018, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 4:22 PM
Unknown Object (File)
Feb 26 2024, 2:31 AM
Unknown Object (File)
Jan 15 2024, 5:09 AM
Unknown Object (File)
Jan 13 2024, 3:38 AM
Unknown Object (File)
Jan 6 2024, 11:43 AM
Unknown Object (File)
Jan 6 2024, 11:43 AM
Unknown Object (File)
Jan 6 2024, 11:43 AM
Unknown Object (File)
Jan 4 2024, 10:58 PM
Subscribers

Details

Reviewers
None
Summary

New common routines were added to kern/subr_clock.c for converting between calendrical time expressed in BCD and struct timespec. The new functions return EINVAL on error, as expected when the clock hardware does not provide valid time.

Test Plan

This code compiles, but has not been tested yet on any x86 hardware (or emulation).

Code has now been run-tested (see PR 224813).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14049

Event Timeline

Follow changes in D13730... the conversion routines now take a bool flag to indicate whether AM/PM mode conversions need to be done. atrtc always operates in 24-hour mode.