Page MenuHomeFreeBSD
Differential D13731

Convert the x86 RTC driver to use new validated BCD<->timespec conversions
AbandonedPublic
Actions

Authored by • ian on Jan 1 2018, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 1:28 AM
Unknown Object (File)
Dec 23 2024, 5:18 AM
Unknown Object (File)
Dec 22 2024, 4:52 AM
Unknown Object (File)
Dec 12 2024, 5:27 PM
Unknown Object (File)
Nov 28 2024, 4:12 PM
Unknown Object (File)
Nov 26 2024, 9:50 AM
Unknown Object (File)
Nov 14 2024, 4:24 PM
Unknown Object (File)
Oct 29 2024, 6:39 AM
View All 56 Files
Subscribers
imp

Details

Reviewers
None
Summary

New common routines were added to kern/subr_clock.c for converting between calendrical time expressed in BCD and struct timespec. The new functions return EINVAL on error, as expected when the clock hardware does not provide valid time.

Test Plan

This code compiles, but has not been tested yet on any x86 hardware (or emulation).

Code has now been run-tested (see PR 224813).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14249

Event Timeline

• ian created this revision.Jan 1 2018, 11:52 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 11:52 PM
• ian added a parent revision: D13730: Add RTC clock conversions for BCD values, with non-panic validation..Jan 1 2018, 11:53 PM
• ian updated this revision to Diff 37730.Jan 10 2018, 4:21 PM

Follow changes in D13730... the conversion routines now take a bool flag to indicate whether AM/PM mode conversions need to be done. atrtc always operates in 24-hour mode.

• ian edited the test plan for this revision. (Show Details)Jan 15 2018, 4:39 PM
• ian abandoned this revision.Jan 16 2018, 4:57 AM

Committed as r328005

Revision Contents
Changeset List

PathSize
sys/
x86/
isa/
59 lines

Diff 37730

View Options

sys/x86/isa/atrtc.c

Loading...