Convert the x86 RTC driver to use new validated BCD<->timespec conversions
AbandonedPublic
Actions

Authored by • ian on Jan 1 2018, 11:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 19, 7:56 PM

	Unknown Object (File)
	Sun, May 18, 2:52 AM

	Unknown Object (File)
	Apr 15 2025, 5:51 PM

	Unknown Object (File)
	Apr 12 2025, 9:25 PM

	Unknown Object (File)
	Mar 26 2025, 4:43 AM

	Unknown Object (File)
	Mar 13 2025, 11:19 AM

	Unknown Object (File)
	Mar 2 2025, 10:22 PM

	Unknown Object (File)
	Feb 20 2025, 5:39 PM

View All 64 Files

Subscribers

imp

Details

Reviewers: None

Summary

New common routines were added to kern/subr_clock.c for converting between calendrical time expressed in BCD and struct timespec. The new functions return EINVAL on error, as expected when the clock hardware does not provide valid time.

Test Plan

This code compiles, but has not been tested yet on any x86 hardware (or emulation).

Code has now been run-tested (see PR 224813).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 14249

Event Timeline

• ian created this revision.Jan 1 2018, 11:52 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 11:52 PM

• ian added a parent revision: D13730: Add RTC clock conversions for BCD values, with non-panic validation..Jan 1 2018, 11:53 PM

Follow changes in D13730... the conversion routines now take a bool flag to indicate whether AM/PM mode conversions need to be done. atrtc always operates in 24-hour mode.

• ian edited the test plan for this revision. (Show Details)Jan 15 2018, 4:39 PM

Committed as r328005

Revision Contents
Changeset List

Path

Size

sys/

x86/

isa/

atrtc.c

59 lines

Diff 37730

View Options

Convert the x86 RTC driver to use new validated BCD<->timespec conversionsAbandonedPublicActions