New port: devel/py-llvmcpy: Python bindings for LLVM auto-generated from the LLVM-C API
ClosedPublic

Authored by yuri on Mon, Jan 1, 5:58 PM.

Details

Summary

Python bindings for LLVM auto-generated from the LLVM-C API

Useful for code analysis tools.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yuri created this revision.Mon, Jan 1, 5:58 PM
yuri updated this revision to Diff 37361.Mon, Jan 1, 6:02 PM

.

Updating D13724: New port: devel/py-llvmcpy: Python bindings for LLVM auto-generated from the LLVM-C API

Useful for code analysis tools.

yuri retitled this revision from New port: devel/py-llvmcpy: Python bindings for LLVM auto-generated from the LLVM-C API Useful for code analysis tools. to New port: devel/py-llvmcpy: Python bindings for LLVM auto-generated from the LLVM-C API.Tue, Jan 2, 1:42 AM
yuri edited the summary of this revision. (Show Details)
tcberner requested changes to this revision.Tue, Jan 9, 9:12 PM
tcberner added inline comments.
devel/py-llvmcpy/Makefile
25 ↗(On Diff #37391)

Did you see:

llvmcpy/llvm.py:llvm_config = env("LLVM_CONFIG","llvm-config39")

so, how about something like

CONFIGURE_ENV= LLVM_CONFIG=llvm-config${LLVM_VERSION}

instead of this ugly sed?

This revision now requires changes to proceed.Tue, Jan 9, 9:12 PM
tcberner added inline comments.Tue, Jan 9, 9:13 PM
devel/py-llvmcpy/Makefile
25 ↗(On Diff #37391)

ah, is this during run, not build time...

yuri marked 2 inline comments as done.Tue, Jan 9, 10:31 PM
yuri added inline comments.
devel/py-llvmcpy/Makefile
25 ↗(On Diff #37391)

Yes, this is a runtime environment variable, not the build time.
So it wouldn't work.

This package doesn't touch llvm during build.
It only looks for the llvm headers and shared libs during the runtime.

yuri added a comment.EditedTue, Jan 9, 10:33 PM

I picked llvm-39 as the highest supported based on what they say. It actually should be 40 or 50, but they didn't test it this way.

yuri marked an inline comment as done.Wed, Jan 10, 8:02 AM
yuri requested review of this revision.Fri, Jan 12, 3:13 PM
tcberner accepted this revision.Mon, Jan 15, 9:51 AM
This revision is now accepted and ready to land.Mon, Jan 15, 9:51 AM
This revision was automatically updated to reflect the committed changes.