Create Mk/Uses/eigen.mk
ClosedPublic

Authored by tcberner on Sun, Dec 31, 12:56 AM.

Details

Summary
  • supported arguments <2,3>,[<build,run>]
  • A unique version 2 or 3 is required
  • Optionally
    • build -> BUILD_DEPENDS only
    • run -> RUN_DEPENDS only
    • build,run / run,build -> BUILD_DEPENDS and RUN_DEPENDS
    • <none> -> BUILD_DEPNDS only
Test Plan
  • actually test it =) did not yet get to it

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Sun, Dec 31, 12:56 AM
tcberner edited the summary of this revision. (Show Details)Sun, Dec 31, 12:57 AM
mat added inline comments.Sun, Dec 31, 9:48 AM
Mk/Uses/eigen.mk
44 ↗(On Diff #37272)

It actually does not use LIB_DEPENDS ;-)

45–53 ↗(On Diff #37272)

It could be a bit simpler:

.  if ! empty(eigen_ARGS:Mrun)
​RUN_DEPENDS+=        ${_EIGEN_DEP}
​.  else
BUILD_DEPENDS+=      ${_EIGEN_DEP}
.  endif
tcberner added inline comments.Sun, Dec 31, 9:57 AM
Mk/Uses/eigen.mk
45–53 ↗(On Diff #37272)

wouldn't that break 'build,run'?

tcberner updated this revision to Diff 37301.Sun, Dec 31, 9:57 AM

Fix the comment.

rakuco added a subscriber: rakuco.Sun, Dec 31, 3:06 PM

It'd be good if you could take a look at the 2 ports that claim to have a runtime dependency on Eigen: unless they're actually building programs themselves, it doesn't make much sense for them to runtime-depend on a header-only library.

Now you need to bump PORTREVISION in those ports too. And it also means you can get rid of USES=eigen:run.

tcberner updated this revision to Diff 37312.Sun, Dec 31, 3:35 PM

... and bump the revisions.

...right, stupid me =)

I think I'll keep eigen:run for now, as I believe there will be a new port that will need it.

rakuco accepted this revision.Sun, Dec 31, 3:56 PM
tcberner updated this revision to Diff 37316.Sun, Dec 31, 5:50 PM

Add CHANGES entry.

mat accepted this revision as: portmgr.Tue, Jan 2, 2:26 PM
mat added inline comments.
Mk/Uses/eigen.mk
45–53 ↗(On Diff #37272)

Mmmm, yes, it would.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 2, 4:49 PM
Closed by commit rP457914: New USES=eigen (authored by tcberner, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.