Create Mk/Uses/eigen.mk

[tcberner]

Summary

• supported arguments <2,3>,[<build,run>]
• A unique version 2 or 3 is required
• Optionally
  • build -> BUILD_DEPENDS only
  • run -> RUN_DEPENDS only
  • build,run / run,build -> BUILD_DEPENDS and RUN_DEPENDS
  • <none> -> BUILD_DEPNDS only

Test Plan

• actually test it =) did not yet get to it

[mat]

Mk/Uses/eigen.mk

44 ↗

(On Diff #37272)

It actually does not use LIB_DEPENDS ;-)

45–53 ↗

(On Diff #37272)

It could be a bit simpler:

.  if ! empty(eigen_ARGS:Mrun)
​RUN_DEPENDS+=        ${_EIGEN_DEP}
​.  else
BUILD_DEPENDS+=      ${_EIGEN_DEP}
.  endif

[tcberner]

Mk/Uses/eigen.mk

45–53 ↗

(On Diff #37272)

wouldn't that break 'build,run'?

[tcberner]

Fix the comment.

[rakuco]

It'd be good if you could take a look at the 2 ports that claim to have a runtime dependency on Eigen: unless they're actually building programs themselves, it doesn't make much sense for them to runtime-depend on a header-only library.

[tcberner]

Make eigen only a build depend in

• graphics/movit [1]
• biology/iqtree [2]

[1] http://libregraphicsworld.org/blog/entry/introducing-movit-free-library-for-gpu-side-video-processing
[2] http://www.iqtree.org/doc/Compilation-Guide

[rakuco]

In D13702#286800, @tcberner wrote:

Make eigen only a build depend in

• graphics/movit [1]
• biology/iqtree [2]

[1] http://libregraphicsworld.org/blog/entry/introducing-movit-free-library-for-gpu-side-video-processing
[2] http://www.iqtree.org/doc/Compilation-Guide

Now you need to bump PORTREVISION in those ports too. And it also means you can get rid of USES=eigen:run.

[tcberner]

... and bump the revisions.

[tcberner]

...right, stupid me =)

I think I'll keep eigen:run for now, as I believe there will be a new port that will need it.

[tcberner]

Add CHANGES entry.

[mat]

Mk/Uses/eigen.mk

45–53 ↗

(On Diff #37272)

Mmmm, yes, it would.