Page MenuHomeFreeBSD

Create Mk/Uses/eigen.mk
ClosedPublic

Authored by tcberner on Dec 31 2017, 12:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 12:27 PM
Unknown Object (File)
Feb 14 2024, 2:09 AM
Unknown Object (File)
Feb 9 2024, 11:22 PM
Unknown Object (File)
Jan 21 2024, 2:57 PM
Unknown Object (File)
Jan 8 2024, 10:04 AM
Unknown Object (File)
Dec 31 2023, 9:19 AM
Unknown Object (File)
Dec 31 2023, 9:19 AM
Unknown Object (File)
Dec 31 2023, 9:19 AM
Subscribers

Details

Summary
  • supported arguments <2,3>,[<build,run>]
  • A unique version 2 or 3 is required
  • Optionally
    • build -> BUILD_DEPENDS only
    • run -> RUN_DEPENDS only
    • build,run / run,build -> BUILD_DEPENDS and RUN_DEPENDS
    • <none> -> BUILD_DEPNDS only
Test Plan
  • actually test it =) did not yet get to it

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mk/Uses/eigen.mk
44 ↗(On Diff #37272)

It actually does not use LIB_DEPENDS ;-)

45–53 ↗(On Diff #37272)

It could be a bit simpler:

.  if ! empty(eigen_ARGS:Mrun)
​RUN_DEPENDS+=        ${_EIGEN_DEP}
​.  else
BUILD_DEPENDS+=      ${_EIGEN_DEP}
.  endif
Mk/Uses/eigen.mk
45–53 ↗(On Diff #37272)

wouldn't that break 'build,run'?

It'd be good if you could take a look at the 2 ports that claim to have a runtime dependency on Eigen: unless they're actually building programs themselves, it doesn't make much sense for them to runtime-depend on a header-only library.

Now you need to bump PORTREVISION in those ports too. And it also means you can get rid of USES=eigen:run.

... and bump the revisions.

...right, stupid me =)

I think I'll keep eigen:run for now, as I believe there will be a new port that will need it.

mat added inline comments.
Mk/Uses/eigen.mk
45–53 ↗(On Diff #37272)

Mmmm, yes, it would.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2018, 4:49 PM
Closed by commit rP457914: New USES=eigen (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.