Page MenuHomeFreeBSD

New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging
ClosedPublic

Authored by yuri on Dec 31 2017, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 7:41 PM
Unknown Object (File)
Jan 15 2024, 3:56 AM
Unknown Object (File)
Jan 11 2024, 1:07 PM
Unknown Object (File)
Jan 3 2024, 9:21 AM
Unknown Object (File)
Dec 31 2023, 11:30 PM
Unknown Object (File)
Dec 24 2023, 2:07 PM
Unknown Object (File)
Dec 21 2023, 11:24 PM
Unknown Object (File)
Dec 20 2023, 2:37 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13993
Build 14186: arc lint + arc unit

Event Timeline

mat requested changes to this revision.Dec 31 2017, 9:41 AM
mat added inline comments.
net/nncp/Makefile
31

You cannot install sample newsyslog files in the newsyslog.conf.d directory, as all the files in it are used.

This revision now requires changes to proceed.Dec 31 2017, 9:41 AM
net/nncp/Makefile
5

^DISTVERSION

yuri added inline comments.
net/nncp/Makefile
5

The portlint maintainer doesn't see this stated in the PHB: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224002
He closed my request.

yuri marked an inline comment as done.

Rearranged conf files to avoid .sample being in etc/newsyslog.conf.d/

net/nncp/Makefile
31

I do not understand why this is so complicated.

Please have a look at 8.3. Configuration Files.

yuri added inline comments.
net/nncp/Makefile
31

It actually follows PHB section 8.3.
It creates a .conf file in etc/ using @sample, and links the real config file etc/newsyslog.conf.d/nncp.conf to it.

Could you please explain what's wrong with this?

yuri marked an inline comment as done.

The submitter verified that it works, and corrected one typo.

@mat, if you don't have any objections, could you please unblock this?

net/nncp/Makefile
31

Yes, I could.

@sample etc/nncp.conf.sample ​etc/newsyslog.conf.d/nncp.conf
yuri marked 2 inline comments as done.

.

As long as mat is fine with it too now, this is good to go.

yuri retitled this revision from New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging to New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging {PENDING portmgr@ approval}.Jan 9 2018, 10:28 PM

Can this be unblocked by portmgr@?

It never was blocked by portmgr.

This revision is now accepted and ready to land.Jan 29 2018, 11:47 AM
yuri retitled this revision from New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging {PENDING portmgr@ approval} to New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging.Jan 29 2018, 4:07 PM
This revision was automatically updated to reflect the committed changes.