New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging {PENDING portmgr@ approval}
Needs ReviewPublic

Authored by yuri on Sun, Dec 31, 12:23 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14062
Build 14246: arc lint + arc unit
yuri created this revision.Sun, Dec 31, 12:23 AM
mat requested changes to this revision.Sun, Dec 31, 9:41 AM
mat added inline comments.
net/nncp/Makefile
31

You cannot install sample newsyslog files in the newsyslog.conf.d directory, as all the files in it are used.

This revision now requires changes to proceed.Sun, Dec 31, 9:41 AM
tcberner added inline comments.Sun, Dec 31, 9:50 AM
net/nncp/Makefile
5

^DISTVERSION

yuri marked an inline comment as done.Sun, Dec 31, 10:03 AM
yuri added inline comments.
net/nncp/Makefile
5

The portlint maintainer doesn't see this stated in the PHB: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224002
He closed my request.

yuri updated this revision to Diff 37303.Sun, Dec 31, 10:28 AM
yuri marked an inline comment as done.

Rearranged conf files to avoid .sample being in etc/newsyslog.conf.d/

yuri marked 2 inline comments as done.Sun, Dec 31, 10:29 AM
mat added inline comments.Sun, Dec 31, 10:25 PM
net/nncp/Makefile
32

I do not understand why this is so complicated.

Please have a look at 8.3. Configuration Files.

yuri marked an inline comment as done.Sun, Dec 31, 11:56 PM
yuri added inline comments.
net/nncp/Makefile
32

It actually follows PHB section 8.3.
It creates a .conf file in etc/ using @sample, and links the real config file etc/newsyslog.conf.d/nncp.conf to it.

Could you please explain what's wrong with this?

yuri updated this revision to Diff 37356.Mon, Jan 1, 5:22 PM
yuri marked an inline comment as done.

The submitter verified that it works, and corrected one typo.

@mat, if you don't have any objections, could you please unblock this?

mat added inline comments.Tue, Jan 2, 11:52 AM
net/nncp/Makefile
32

Yes, I could.

@sample etc/nncp.conf.sample ​etc/newsyslog.conf.d/nncp.conf
yuri updated this revision to Diff 37407.Tue, Jan 2, 11:58 AM
yuri marked 2 inline comments as done.

.

tcberner accepted this revision.Tue, Jan 9, 9:52 PM

As long as mat is fine with it too now, this is good to go.

yuri retitled this revision from New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging to New port: net/nncp: Utilities for secure store-and-forward files and mail exchanging {PENDING portmgr@ approval}.Tue, Jan 9, 10:28 PM