Paths

Table of Contentst

Differential D13689

New port: math/tmv: Fast, intuitive linear algebra library for C++
ClosedPublic
Actions

Authored by yuri on Dec 30 2017, 6:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 17, 12:19 PM

	Unknown Object (File)
	Tue, Feb 17, 5:45 AM

	Unknown Object (File)
	Mon, Feb 16, 5:42 PM

	Unknown Object (File)
	Sun, Feb 8, 1:46 PM

	Unknown Object (File)
	Sun, Feb 8, 11:44 AM

	Unknown Object (File)
	Sun, Feb 8, 4:17 AM

	Unknown Object (File)
	Sat, Feb 7, 8:05 PM

	Unknown Object (File)
	Sat, Feb 7, 5:31 PM

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++

Summary

Fast, intuitive linear algebra library for C++

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Dec 30 2017, 6:40 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 30 2017, 6:40 AM

.

Harbormaster completed remote builds in B13939: Diff 37219.Dec 30 2017, 6:47 AM

mat added inline comments.Dec 30 2017, 8:42 AM

math/tmv/Makefile
26–27 ↗	(On Diff #37219)	You could simply set: MAKEFILE= ${FILESDIR}/Makefile
29–33 ↗	(On Diff #37219)	As the Makefile is provided by the port, any reason not to do all this in files/Makefile ? For example, use `${BSD_INSTALL_LIB}` to install the `.so`, saving the trouble of stripping afterwards.

yuri marked 2 inline comments as done.Dec 30 2017, 9:06 AM

.

Harbormaster completed remote builds in B13942: Diff 37228.Dec 30 2017, 9:06 AM

mat added inline comments.Dec 30 2017, 9:16 AM

math/tmv/files/Makefile
30–31 ↗	(On Diff #37228)	This is always stripping which is bad. Any reason not to use `${BSD_INSTALL_LIB}` here ?

.

Harbormaster completed remote builds in B13945: Diff 37230.Dec 30 2017, 9:20 AM

yuri marked an inline comment as done.Dec 30 2017, 9:20 AM

Everything has been resolved here.

tcberner accepted this revision.Jan 19 2018, 9:34 PM

This revision is now accepted and ready to land.Jan 19 2018, 9:34 PM

Closed by commit rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++ (authored by yuri). · Explain WhyJan 26 2018, 11:15 PM

This revision was automatically updated to reflect the committed changes.

yuri mentioned this in rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++.

Revision Contents
Changeset List

Path

Size

head/

math/

1 line

tmv/

31 lines

3 lines

files/

33 lines

8 lines

106 lines

Diff 38503

head/math/Makefile

Loading...

head/math/tmv/Makefile

Loading...

head/math/tmv/distinfo

Loading...

head/math/tmv/files/Makefile

Loading...

head/math/tmv/pkg-descr

Loading...

head/math/tmv/pkg-plist

Loading...