New port: math/tmv: Fast, intuitive linear algebra library for C++
Needs ReviewPublic

Authored by yuri on Sat, Dec 30, 6:40 AM.

Details

Reviewers
tcberner
adamw
Summary

Fast, intuitive linear algebra library for C++

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13945
Build 14141: arc lint + arc unit
yuri created this revision.Sat, Dec 30, 6:40 AM
mat added inline comments.Sat, Dec 30, 8:42 AM
math/tmv/Makefile
27–28

You could simply set:

MAKEFILE= ${FILESDIR}/Makefile
30–34

As the Makefile is provided by the port, any reason not to do all this in files/Makefile ?

For example, use ${BSD_INSTALL_LIB} to install the .so, saving the trouble of stripping afterwards.

yuri marked 2 inline comments as done.Sat, Dec 30, 9:06 AM
mat added inline comments.Sat, Dec 30, 9:16 AM
math/tmv/files/Makefile
31–32

This is always stripping which is bad. Any reason not to use ${BSD_INSTALL_LIB} here ?

yuri marked an inline comment as done.Sat, Dec 30, 9:20 AM
yuri added a comment.Wed, Jan 10, 6:17 PM

Everything has been resolved here.