Page MenuHomeFreeBSD
Differential D13689

New port: math/tmv: Fast, intuitive linear algebra library for C++
ClosedPublic
Actions

Authored by yuri on Dec 30 2017, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 25 2024, 6:23 AM
Unknown Object (File)
Jan 22 2024, 7:59 PM
Unknown Object (File)
Dec 20 2023, 3:29 AM
Unknown Object (File)
Dec 18 2023, 5:23 AM
Unknown Object (File)
Dec 8 2023, 5:35 AM
Unknown Object (File)
Dec 2 2023, 7:39 AM
Unknown Object (File)
Nov 10 2023, 9:11 AM
Unknown Object (File)
Nov 7 2023, 5:05 AM
View All 27 Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++
Summary

Fast, intuitive linear algebra library for C++

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13945
Build 14141: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 30 2017, 6:40 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 30 2017, 6:40 AM
yuri updated this revision to Diff 37219.Dec 30 2017, 6:47 AM

.

Harbormaster completed remote builds in B13939: Diff 37219.Dec 30 2017, 6:47 AM
mat added inline comments.Dec 30 2017, 8:42 AM
math/tmv/Makefile
27–28

You could simply set:

MAKEFILE= ${FILESDIR}/Makefile
30–34

As the Makefile is provided by the port, any reason not to do all this in files/Makefile ?

For example, use ${BSD_INSTALL_LIB} to install the .so, saving the trouble of stripping afterwards.

yuri marked 2 inline comments as done.Dec 30 2017, 9:06 AM
yuri updated this revision to Diff 37228.Dec 30 2017, 9:06 AM

.

Harbormaster completed remote builds in B13942: Diff 37228.Dec 30 2017, 9:06 AM
mat added inline comments.Dec 30 2017, 9:16 AM
math/tmv/files/Makefile
31–32

This is always stripping which is bad. Any reason not to use ${BSD_INSTALL_LIB} here ?

yuri updated this revision to Diff 37230.Dec 30 2017, 9:20 AM

.

Harbormaster completed remote builds in B13945: Diff 37230.Dec 30 2017, 9:20 AM
yuri marked an inline comment as done.Dec 30 2017, 9:20 AM
yuri added a comment.Jan 10 2018, 6:17 PM

Everything has been resolved here.

tcberner accepted this revision.Jan 19 2018, 9:34 PM
This revision is now accepted and ready to land.Jan 19 2018, 9:34 PM
Closed by commit rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++ (authored by yuri). · Explain WhyJan 26 2018, 11:15 PM
This revision was automatically updated to reflect the committed changes.
yuri mentioned this in rP460061: New port: math/tmv: Fast, intuitive linear algebra library for C++.

Revision Contents
Changeset List

PathSize
math/
1 line
31 lines
3 lines
32 lines
8 lines
106 lines

Diff 37230

View Options

math/Makefile

Loading...
View Options

math/tmv/

Loading...
View Options

math/tmv/Makefile

Loading...
View Options

math/tmv/distinfo

Loading...
View Options

math/tmv/files/

Loading...
View Options

math/tmv/files/Makefile

Loading...
View Options

math/tmv/pkg-descr

Loading...
View Options

math/tmv/pkg-plist

Loading...