Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 13949 Build 14144: arc lint + arc unit
Event Timeline
sysutils/vzvol/Makefile | ||
---|---|---|
44 | This seems like it is installing scripts, maybe you should use INSTALL_SCRIPT. Also, I am not sure there is a point of installing the Linux related scripts. | |
48 | Never, never, never, never, use cp to install files in STAGEDIR. |
sysutils/vzvol/pkg-plist | ||
---|---|---|
20 | ^ also, call me out on my prejudice, but given that these are linux scripts, I would assume you need a bash runtime dependency? |
sysutils/vzvol/pkg-plist | ||
---|---|---|
20 | No, I checked scripts and they are meant to be Bourne shell. However, shellcheck finds some errors in them. I asked upstream to correct and create a release. IMO, it will be reasonable to wait a few days in a hope that they will respond. |
sysutils/vzvol/Makefile | ||
---|---|---|
44 |
These are for Linux file systems, not for Linux itself. They allow to manage Linux filesystems like ext2. |
sysutils/vzvol/pkg-plist | ||
---|---|---|
20 | good job :) |
Submitter asked to transfer it to freebsdfrau to expedite this item.
She is welcome to take it!
Committed by dteske@ on request by the submitter to avoid long a wait while it awaits approval.