inline ccbque.h into scsi_low.h. The file isn't MD, so shouldn't live
in i386/isa. It's only used by scsi_low, so move it there so no new
clients accidentally grow. scsi_low may not even still work, and the
locking here is still SPL based. CAM should do the right thing, but
I've received no reports of these cards still working. At least it
compiles still and there's one fewer files in sys/i386/isa.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13911 Build 14113: arc lint + arc unit
Event Timeline
Comment Actions
Since the code is copied and history is dropped, it is reasonable to do a minimal cleanup of the code.
sys/cam/scsi/scsi_low.h | ||
---|---|---|
125 | Use ANSI C ? | |
136 | Perhaps remove spl()s. | |
142 | You can use the opportunity and put '{' on the previous line for style. | |
146 | And there and in several other places. | |
149 | M_NOWAIT | M_ZERO. Then bzero() call below can be removed, and goto out can be replaced with return (cb). |
sys/cam/scsi/scsi_low.h | ||
---|---|---|
175 | This turns out to be a clear-only flag. Not fixing *THAT*, but further evidence this code can't possibly work. |