Differential D13666

Fix potential TOCTTOU bug in the geli tests
ClosedPublic
Actions

Authored by asomers on Dec 28 2017, 6:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 30, 8:51 AM

	Unknown Object (File)
	Thu, Nov 27, 2:09 PM

	Unknown Object (File)
	Fri, Nov 21, 1:46 AM

	Unknown Object (File)
	Thu, Nov 20, 11:15 PM

	Unknown Object (File)
	Thu, Nov 20, 11:12 PM

	Unknown Object (File)
	Thu, Nov 20, 11:12 PM

	Unknown Object (File)
	Thu, Nov 20, 11:11 PM

	Unknown Object (File)
	Thu, Nov 20, 11:04 PM

Subscribers

Details

Reviewers

Commits

rS327346: Fix potential TOCTTOU bug in the geli tests

Summary

Fix potential TOCTTOU bug in the geli tests

This change mostly reverts r293436, which introduced the bug due to a belief
that geli(8) would allocate md(4) devices by itself. However, that belief is
incorrect. Instead of using linear probing to find available md(4) numbers,
it's best to use the existing attach_md function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13903
Build 14107: arc lint + arc unit

Event Timeline

asomers created this revision.Dec 28 2017, 6:05 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2017, 6:05 PM

Harbormaster completed remote builds in B13900: Diff 37148.Dec 28 2017, 6:05 PM

Add missing cleanup step

Harbormaster completed remote builds in B13903: Diff 37151.Dec 28 2017, 7:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2017, 4:06 PM

Closed by commit rS327346: Fix potential TOCTTOU bug in the geli tests (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

sys/

geom/

class/

eli/

attach_d_test.sh

16 lines

17 lines

configure_b_B_test.sh

36 lines

42 lines

detach_l_test.sh

20 lines

44 lines

102 lines

16 lines

init_alias_test.sh

12 lines

init_i_P_test.sh

4 lines

18 lines

integrity_copy_test.sh

42 lines

integrity_data_test.sh

16 lines

integrity_hmac_test.sh

16 lines

34 lines

18 lines

onetime_a_test.sh

14 lines

onetime_d_test.sh

16 lines

onetime_test.sh

16 lines

readonly_test.sh

26 lines

3 lines

50 lines

Diff 37151

tests/sys/geom/class/eli/attach_d_test.sh

Loading...

tests/sys/geom/class/eli/conf.sh

Loading...

tests/sys/geom/class/eli/configure_b_B_test.sh

Loading...

tests/sys/geom/class/eli/delkey_test.sh

Loading...

tests/sys/geom/class/eli/detach_l_test.sh

Loading...

tests/sys/geom/class/eli/init_B_test.sh

Loading...

tests/sys/geom/class/eli/init_J_test.sh

Loading...

tests/sys/geom/class/eli/init_a_test.sh

Loading...

tests/sys/geom/class/eli/init_alias_test.sh

Loading...

tests/sys/geom/class/eli/init_i_P_test.sh

Loading...

tests/sys/geom/class/eli/init_test.sh

Loading...

tests/sys/geom/class/eli/integrity_copy_test.sh

Loading...

tests/sys/geom/class/eli/integrity_data_test.sh

Loading...

tests/sys/geom/class/eli/integrity_hmac_test.sh

Loading...

tests/sys/geom/class/eli/kill_test.sh

Loading...

tests/sys/geom/class/eli/nokey_test.sh

Loading...

tests/sys/geom/class/eli/onetime_a_test.sh

Loading...

tests/sys/geom/class/eli/onetime_d_test.sh

Loading...

tests/sys/geom/class/eli/onetime_test.sh

Loading...

tests/sys/geom/class/eli/readonly_test.sh

Loading...

tests/sys/geom/class/eli/resize_test.sh

Loading...

tests/sys/geom/class/eli/setkey_test.sh

Loading...