Page MenuHomeFreeBSD

Fix potential TOCTTOU bug in the geli tests
ClosedPublic

Authored by asomers on Dec 28 2017, 6:05 PM.

Details

Summary

Fix potential TOCTTOU bug in the geli tests

This change mostly reverts r293436, which introduced the bug due to a belief
that geli(8) would allocate md(4) devices by itself. However, that belief is
incorrect. Instead of using linear probing to find available md(4) numbers,
it's best to use the existing attach_md function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2017, 4:06 PM
This revision was automatically updated to reflect the committed changes.