Differential D13653

math/sundials: Changed to using <opt>_IMPLIES for HYPRE and PETSC options, and removed the .include clause
ClosedPublic
Actions

Authored by yuri on Dec 27 2017, 6:43 PM.

Tags

None

Referenced Files

	F163100491: D13653.id37122.diff
	Mon, Jul 20, 2:17 AM

	Unknown Object (File)
	Sun, Jul 19, 3:47 AM

	Unknown Object (File)
	Sat, Jul 18, 2:41 PM

	Unknown Object (File)
	Sat, Jul 18, 1:45 PM

	Unknown Object (File)
	Sat, Jul 18, 10:25 AM

	Unknown Object (File)
	Wed, Jul 8, 8:35 AM

	Unknown Object (File)
	Sat, Jul 4, 7:10 PM

	Unknown Object (File)
	Sat, Jul 4, 5:57 PM

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP457590: math/sundials: Changed to using <opt>_IMPLIES for HYPRE and PETSC options, and…

Summary

<opt>_IMPLIES

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13884
Build 14093: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 27 2017, 6:43 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 27 2017, 6:43 PM

Harbormaster completed remote builds in B13872: Diff 37102.Dec 27 2017, 6:43 PM

Jan Beich suggested this change in a follow-up message.

yuri retitled this revision from math/sundials: Changed to using <opt>_IMPLIES for HYPRE and PERSC options, and removed the .include clause to math/sundials: Changed to using <opt>_IMPLIES for HYPRE and PETSC options, and removed the .include clause.Dec 27 2017, 8:57 PM

tcberner requested changes to this revision.Dec 28 2017, 4:24 AM

tcberner added inline comments.

math/sundials/Makefile
60–61	^s/SUPERLU_/SUPERLUMT/g?

This revision now requires changes to proceed.Dec 28 2017, 4:24 AM

Yes, SUPERLUMT options was broken, thanks for noticing!
This is now fixed.

Harbormaster completed remote builds in B13884: Diff 37122.Dec 28 2017, 4:54 AM

yuri marked an inline comment as done.Dec 29 2017, 5:36 PM

tcberner accepted this revision.Dec 29 2017, 11:33 PM

This revision is now accepted and ready to land.Dec 29 2017, 11:33 PM

Closed by commit rP457590: math/sundials: Changed to using <opt>_IMPLIES for HYPRE and PETSC options, and… (authored by yuri). · Explain WhyDec 30 2017, 8:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

math/

sundials/

32 lines

files/

patch-config_SundialsSuperLUMT.cmake

11 lines

9 lines

Diff 37122

math/sundials/Makefile

Loading...

math/sundials/files/patch-config_SundialsSuperLUMT.cmake

Loading...

math/sundials/pkg-plist

Loading...