New port: math/adept: Combined array and automatic differentiation library in C++

[yuri]

Summary

Combined array and automatic differentiation library in C++

[tcberner]

math/adept/Makefile

1 ↗

(On Diff #37033)

^ I would prefer it without this line.

[yuri]

.

[adamw]

head/math/adept/Makefile

22

Wait, sorry, this is problematic. pdftex is a gigantic dependency, and we never bring in huge dependencies for DOCS. Things with huge dependencies should be under something like PDFTEX_DOCS (still enabled by default) so that users have some idea what they're getting into if they keep it enabled.

25

This loses MAKE_ARGS. I usually recommend using ${DO_MAKE_BUILD}.

post-build-PDFTEX_DOCS-on:
    ${DO_MAKE_BUILD} -C ${WRKSRC}/doc

[yuri]

head/math/adept/Makefile

22

It wants the `pdflatex``` command to build pdfs from latex files.

25

This loses MAKE_ARGS.

This particular command doesn't need make arguments.

[yuri]

Adam, I've committed this before you made comments, sorry.

[adamw]

In D13635#285151, @yuri wrote:

Adam, I've committed this before you made comments, sorry.

That DOCS option needs to be changed. Please do a follow-up commit for it.

[yuri]

head/math/adept/Makefile

22

Adam, but there is no such standard option: `PDFTEX_DOCS``. People who have blanket OPTIONS_UNSET= DOCS` in their make.conf will be upset because this one will still be on?

[adamw]

head/math/adept/Makefile

22

As an example, there are 75 ports that use a DOXYGEN option instead of DOCS.

DOCS cannot bring in LaTeX. This is a much larger surprise than a second option to control docs (which many ports have). This is policy.

[yuri]

https://reviews.freebsd.org/D13643

[mat]

head/math/adept/Makefile

22

PDF_DOCS