Page MenuHomeFreeBSD

New port: math/adept: Combined array and automatic differentiation library in C++
ClosedPublic

Authored by yuri on Dec 26 2017, 6:50 AM.

Details

Summary

Combined array and automatic differentiation library in C++

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Dec 26 2017, 6:50 AM
tcberner added inline comments.Dec 26 2017, 10:01 AM
math/adept/Makefile
1 ↗(On Diff #37033)

^ I would prefer it without this line.

yuri marked an inline comment as done.Dec 26 2017, 10:05 AM
tcberner accepted this revision.Dec 26 2017, 11:34 AM
This revision is now accepted and ready to land.Dec 26 2017, 11:34 AM
This revision was automatically updated to reflect the committed changes.
adamw added inline comments.Dec 26 2017, 6:25 PM
head/math/adept/Makefile
22

Wait, sorry, this is problematic. pdftex is a gigantic dependency, and we never bring in huge dependencies for DOCS. Things with huge dependencies should be under something like PDFTEX_DOCS (still enabled by default) so that users have some idea what they're getting into if they keep it enabled.

25

This loses MAKE_ARGS. I usually recommend using ${DO_MAKE_BUILD}.

post-build-PDFTEX_DOCS-on:
    ${DO_MAKE_BUILD} -C ${WRKSRC}/doc
yuri marked 2 inline comments as done.Dec 26 2017, 6:33 PM
yuri added inline comments.
head/math/adept/Makefile
22

It wants the `pdflatex``` command to build pdfs from latex files.

25

This loses MAKE_ARGS.

This particular command doesn't need make arguments.

yuri marked 2 inline comments as done.Dec 26 2017, 6:34 PM

Adam, I've committed this before you made comments, sorry.

adamw added a comment.Dec 26 2017, 6:38 PM
In D13635#285151, @yuri wrote:

Adam, I've committed this before you made comments, sorry.

That DOCS option needs to be changed. Please do a follow-up commit for it.

yuri marked an inline comment as done.Dec 26 2017, 6:43 PM
yuri added inline comments.
head/math/adept/Makefile
22

Adam, but there is no such standard option: `PDFTEX_DOCS``. People who have blanket OPTIONS_UNSET= DOCS` in their make.conf will be upset because this one will still be on?

yuri marked 2 inline comments as done.Dec 26 2017, 6:47 PM
adamw added inline comments.Dec 26 2017, 6:48 PM
head/math/adept/Makefile
22

As an example, there are 75 ports that use a DOXYGEN option instead of DOCS.

DOCS cannot bring in LaTeX. This is a much larger surprise than a second option to control docs (which many ports have). This is policy.

mat added inline comments.Dec 27 2017, 2:38 PM
head/math/adept/Makefile
22

PDF_DOCS