dns/mdnsd: Updating to the current revision

[yuri]

Summary

One other port bundled mdnsd, so I first thought that this port needed to be a dependency.
But as it turned out, this port doesn't install headers/lib, so it isn't useful for the original purpose.
Updating it anyway, once I am here.
I notified the upstream maintainer to install headers/libs.

I changed EPOCH because github version number isn't compatible with the previous one, as per portlint.

[adamw]

dns/mdnsd/Makefile

6 ↗

(On Diff #36952)

This version number makes no sense. If the next release is 0.8G, or 0.7H, then PORTEPOCH gets bumped again.

Perhaps setting DISTVERSION to 0.7G.107 would make more sense.

$ pkg version -t 0.7H 0.7G-107
<
$ pkg version -t 0.7H 0.7G.107
>

25 ↗

(On Diff #36952)

Why CONFIGURE_WRKSRC?

[yuri]

dns/mdnsd/Makefile

6 ↗

(On Diff #36952)

Sorry, typo...

I actually meant it this way:

DISTVERSION=    0.7
DISTVERSIONSUFFIX=      G-107-gf4aee59

Package version is `0.7```.

0.7G-107-gf4aee59``` is what ```git describe tags``` gives.

It doesn't fetch it with:

DISTVERSION= 0.7G.107
DISTVERSIONSUFFIX= -gf4aee59

[yuri]

.

[yuri]

dns/mdnsd/Makefile

6 ↗

(On Diff #36952)

The original revision was 0.7G. When I keep it as 0.7G, portlint still complains:

FATAL: Makefile: mdnsd-0.7.g < mdnsd-0.7G_1. Choose another PORTVERSION or bump PORTEPOCH.

I think this is possibly some bug.

25 ↗

(On Diff #36952)

Because files are built there?

[adamw]

dns/mdnsd/Makefile

6 ↗

(On Diff #36952)

Right. You'd have to set DISTNAME as well. But it would avoid this, and future, PORTEPOCH bumps.

6 ↗

(On Diff #36952)

Yes. You're also switching from PORTVERSION to DISTVERSION. And if you do what you're intending, then yes 0.7 < 0.7G.

We don't have to use bizarre version strings just because upstream does. I think you'll be better off in the long run by using a normal-ish version string.

25 ↗

(On Diff #36952)

Ah. Because of cmake:outsource. Got it.

[yuri]

dns/mdnsd/Makefile

6 ↗

(On Diff #36952)

Your suggestion, if I understand it correctly, is this:

PORTNAME=       mdnsd
DISTVERSIONPREFIX=      v
DISTVERSION=    0.7G.107
DISTVERSIONSUFFIX=      -gf4aee59
CATEGORIES=     dns
DISTNAME=       ${GH_ACCOUNT}-${PORTNAME}-${DISTVERSIONPREFIX}0.7G-107${DISTVERSIONSUFFIX}

But portlint still complains:

FATAL: Makefile: mdnsd-0.7.g.107 < mdnsd-0.7G_1. Choose another PORTVERSION or bump PORTEPOCH

[yuri]

I think, `DISTVERSION`` should be set to 0.7, `PORTEPOCH` should be changed once. Later, if they keep updating the letter, this should be handled with `PORTREVISION``.

[adamw]

In D13600#284637, @yuri wrote:

I think, DISTVERSION should be set to 0.7, PORTEPOCH should be changed once. Later, if they keep updating the letter, this should be handled with PORTREVISION.

The problem is that DISTVERSION should change when the actual port version changes. If the next version is 0.7H, the actual port version has changed but DISTVERSION remains the same. Things like patch levels are appropriate for DISTVERSIONSUFFIX, but putting major pieces of the version string into that variable just aren't in spirit with the design.

[mat]

dns/mdnsd/Makefile

8 ↗

(On Diff #36953)

Not needed.

6 ↗

(On Diff #36952)

DISTVERSIONPREFIX=      v
DISTVERSION=    0.7G-107
DISTVERSIONSUFFIX=      -gf4aee59

And remove the DISTNAME processing.

[yuri]

Followed mat's advice in DISTVERSION.

[tcberner]

dns/mdnsd/files/patch-libmdnsd_1035.c

5 ↗

(On Diff #37127)

whith "WTF?"-y patches like these, it's sometimes good to include some explanation at the top :)

ala "this is the error without this" or "this is done because"

[tcberner]

As long as the others are fine with it, this is ok.

Also, did you ask the MAINTAINER?

[yuri]

Asked for maintainer's approval: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225114