Page MenuHomeFreeBSD

New port: sysutils/twmn: Notification system for tiling window managers
ClosedPublic

Authored by yuri on Dec 20 2017, 8:32 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Dec 20 2017, 8:32 PM
adamw added inline comments.Dec 20 2017, 8:50 PM
sysutils/twmn/Makefile
4 ↗(On Diff #36830)

I'm not sure it's a good idea to set this to 1.2. Eventually, upstream might release an actual 1.2, at which point we'd have to bump PORTEPOCH.

I'd suggest 1.1 or g20171216 or something like that.

yuri updated this revision to Diff 36838.Dec 20 2017, 8:59 PM

Updated the version to gYYYYMMDD format for the unreleased port.

adamw accepted this revision.Dec 20 2017, 9:10 PM
This revision is now accepted and ready to land.Dec 20 2017, 9:10 PM
yuri marked an inline comment as done.EditedDec 20 2017, 9:14 PM

@adamw, Should I maybe still commit with version 1.2 because it is in the code, and --version prints it too?

sysutils/twmn/Makefile
4 ↗(On Diff #36830)

Adam, actually they said that the version is 1.2: https://github.com/sboli/twmn/blob/master/twmnc/main.cpp#L15

adamw added a comment.Dec 20 2017, 9:27 PM
In D13563#283729, @yuri wrote:

@adamw, Should I maybe still commit with version 1.2 because it is in the code, and --version prints it too?

Version is often bumped immediately after the prior release. You might communicate with upstream and find out whether they intend to cut an actual tagged release, and if so whether it will be 1.2 or 1.3.

yuri marked an inline comment as done.Dec 20 2017, 9:29 PM
In D13563#283729, @yuri wrote:

@adamw, Should I maybe still commit with version 1.2 because it is in the code, and --version prints it too?

Version is often bumped immediately after the prior release. You might communicate with upstream and find out whether they intend to cut an actual tagged release, and if so whether it will be 1.2 or 1.3.

I asked them to make a tagged release. I think, I will wait for 1-2 days to see if they answer.

This revision was automatically updated to reflect the committed changes.