New port: science/PETSc: Suite of data structures and routines from Argonne National Laboratory
ClosedPublic
Actions

Authored by yuri on Dec 18 2017, 6:20 AM.

Details

Reviewers

tcberner
adamw

Commits

rP456696: New port: science/PETSc: Suite of data structures and routines from Argonne…

Summary

Suite of data structures and routines from Argonne National Laboratory

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13648
Build 13868: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 18 2017, 6:20 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 18 2017, 6:20 AM

Harbormaster completed remote builds in B13637: Diff 36705.Dec 18 2017, 6:20 AM

This project is widely referred to with capitalization: PETSc, so I called it this way.

This project also does all sorts of crazy things during installation: it installs html files and binaries under include/, config files under bin/, etc.

adamw added inline comments.Dec 18 2017, 1:43 PM

science/PETSc/Makefile
5	If people are more likely to look for this port by the name "PETSc", then I commend your instinct to name the port that way!
23	This last line looks more like `CONFIGURE_ENV` than `CONFIGURE_ARGS`.
35	`${FIND} ... -delete` is probably simpler here
39	??

yuri marked 3 inline comments as done.Dec 18 2017, 6:10 PM

yuri added inline comments.

science/PETSc/Makefile
5	Thanks!
23	Their configure procedure explicitly says that these should be in the args. But then, even after this, they still print those warnings... So I would tend to just leave it this way until they refine their build process.
39	Oops, a leftover! Thanks for finding it!