Suite of data structures and routines from Argonne National Laboratory
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This project is widely referred to with capitalization: PETSc, so I called it this way.
This project also does all sorts of crazy things during installation: it installs html files and binaries under include/, config files under bin/, etc.
| science/PETSc/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #36705) | If people are more likely to look for this port by the name "PETSc", then I commend your instinct to name the port that way! |
| 22 ↗ | (On Diff #36705) | This last line looks more like CONFIGURE_ENV than CONFIGURE_ARGS. |
| 34 ↗ | (On Diff #36705) | ${FIND} ... -delete is probably simpler here |
| 38 ↗ | (On Diff #36705) | ?? |
| science/PETSc/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #36705) | Thanks! |
| 22 ↗ | (On Diff #36705) | Their configure procedure explicitly says that these should be in the args. But then, even after this, they still print those warnings... So I would tend to just leave it this way until they refine their build process. |
| 38 ↗ | (On Diff #36705) | Oops, a leftover! Thanks for finding it! |