sysutils/desktop-installer: Update to 0.5.5
ClosedPublic
Actions

Authored by jwb on Dec 18 2017, 3:13 AM.

Details

Reviewers

jrm
wen

Commits

rP456585: sysutils/desktop-installer: Update to 0.5.5

Summary

sysutils/desktop-installer: Update to 0.5.5

Fix perms for k3b, switch suggested pw vault to keepassx2, print driver to hplip, add lilyterm to Lumina setup, other minor enhancements.

Approved by: jrm (mentor) or wen (mentor)
Differential to be added

Test Plan

portlint -C: clean
stage-qa: clean

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jwb created this revision.Dec 18 2017, 3:13 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 18 2017, 3:13 AM

Harbormaster completed remote builds in B13636: Diff 36701.Dec 18 2017, 3:13 AM

jwb edited the summary of this revision. (Show Details)Dec 18 2017, 3:17 AM

jwb edited the test plan for this revision. (Show Details)

jwb added reviewers: jrm, wen.

jrm accepted this revision.Dec 18 2017, 3:21 AM

This revision is now accepted and ready to land.Dec 18 2017, 3:21 AM

jwb edited the summary of this revision. (Show Details)Dec 18 2017, 3:22 AM

jrm added inline comments.Dec 18 2017, 3:24 AM

sysutils/desktop-installer/Makefile
1 ↗	(On Diff #36701)	I recall that this line is fixed once it's been set. I'm not sure why though.

I'm not clear on what you mean, but apparently "svn diff" does not include the tag in its output if that's what you're getting at. I never noticed this before, though. I just home in on the changes.

<<<ROOT@cray.acadix>>> /usr/ports/sysutils/desktop-installer 1031 # head -3 Makefile
# $FreeBSD: head/sysutils/desktop-installer/Makefile 452527 2017-10-20 14:21:36Z swills $

PORTNAME=	desktop-installer
<<<ROOT@cray.acadix>>> /usr/ports/sysutils/desktop-installer 1032 # svn diff
Index: Makefile
===================================================================
--- Makefile	(revision 456570)
+++ Makefile	(working copy)
@@ -1,12 +1,11 @@
-# Created by: Jason Bacon <bacon4000@gmail.com>
 # $FreeBSD$
 
 PORTNAME=	desktop-installer

I just recall being told by mat@ that the 'Created by:' line can/should only be set on a port's first commit, and once it is set, it is immutable. I do not see anything relevant in the Porter's Handbook or the Committer's Guide, so I am not sure if it is a convention or if there will be problems.

Sorry, I missed this during the last review for sysutils/auto-admin.

Oh, that line... I thought you were referring to $FreeBSD$ not showing the svn tag. I apparently misinterpreted our earlier discussion as a call to remove the "Created by" comments. I'll leave it in for this commit, pending clarification.

Sounds good.

Some Phabricator interface quirks:

If you hover over an inline comment you should see a highlight over the lines the comment refers to.
You can mark comments as 'Done', but unintuitively, you have to click Submit at the bottom for the mark to take effect.