New port: x11/hhpc: Small and easy to use console text editor

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224345

[tcberner]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

^ if possible don't add this :)

18 ↗

(On Diff #36623)

^ USES=localbase

25 ↗

(On Diff #36623)

^ single, static file. Why the option?

[yuri]

.

[yuri]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

I know that it is preferred not have Created by in new ports, but there is no such rule, and a lot of ports have it.
I prefer to commit with Created by.

[tcberner]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

Let me explain why I do not like it.

Assume Dimitri stops maintaining the port and someone else picks it up. As it turns our the upgrade to the next version basically requires a whole rewrite of the port makefile, and only few things like PORTNAME stayed the same.

Now the port will still carry the created by line. Even though all but in line have no input from the mentioned autor.

[yuri]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

In such case, the line Created by can be modified.

[tcberner]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

You can certainly try to change it... Just think of the trees and don't print the complaints =)

I think there are better choices for the attribution of work: there is the MAINTAINER in the Makefile and 'Submitted by' in the commit messages respectively.

[adamw]

x11/hhpc/Makefile

1 ↗

(On Diff #36623)

No. The Created by line can NEVER be modified except by the person named in it. The line tracks who created the port, not the last person to overhaul it.

[yuri]

Ok, so can this be committed now?

[mat]

In D13499#282245, @yuri wrote:

Ok, so can this be committed now?

This is pretty rude to ask this soon.
We are all volunteers here, so, before you revive a review, wait at least a couple of days, and when you do, please phrase it in a more considerate way.

[yuri]

In D13499#282337, @mat wrote:

In D13499#282245, @yuri wrote:

Ok, so can this be committed now?

This is pretty rude to ask this soon.
We are all volunteers here, so, before you revive a review, wait at least a couple of days, and when you do, please phrase it in a more considerate way.

Sorry! I didn't mean to be rude, and believe me, I am not a rude person at all. Timeframes haven't been specified anywhere, and people have different paces.