Paths

Table of Contentst

Differential D13498

New port: editors/dte: Small and easy to use console text editor
ClosedPublic
Actions

Authored by yuri on Dec 15 2017, 5:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 12:43 PM

	Unknown Object (File)
	Mon, Dec 23, 11:52 AM

	Unknown Object (File)
	Dec 3 2024, 7:23 AM

	Unknown Object (File)
	Dec 2 2024, 1:29 AM

	Unknown Object (File)
	Dec 1 2024, 6:45 PM

	Unknown Object (File)
	Nov 30 2024, 4:18 AM

	Unknown Object (File)
	Oct 30 2024, 8:54 AM

	Unknown Object (File)
	Oct 30 2024, 8:54 AM

View All 93 Files

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP456692: New port: editors/dte: Small and easy to use console text editor

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224340

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Dec 15 2017, 5:17 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 15 2017, 5:17 AM

Harbormaster completed remote builds in B13578: Diff 36622.Dec 15 2017, 5:17 AM

tcberner added inline comments.Dec 15 2017, 5:38 AM

editors/dte/Makefile
1 ↗	(On Diff #36622)	^ you should ask Dmitri if it's ok to not add this
15 ↗	(On Diff #36622)	^ alphabetize USES
29 ↗	(On Diff #36622)	^ I say it again... an option for a single, static file is not worth it IMHO.

yuri marked 3 inline comments as done.Dec 15 2017, 5:51 AM

yuri added inline comments.

editors/dte/Makefile
15 ↗	(On Diff #36622)	I actually prefer `USES` in the hierarchical order. There is no formal rule that requires sorting them. Please read the Mathieu's post here https://reviews.freebsd.org/D13460: `there are two kind of people, those belonging to the sort police that think it is always better to sort everything even if it does not make any sense, and those who have a more pragmatical way.`
29 ↗	(On Diff #36622)	But I checked last time, the actual overhead of an option is negligible. The README file is added as a doc out of respect for the author who wrote it. On the other hand, there are a lot of users who don't want to see any docs installed, hence the DOCS option.

tcberner added inline comments.Dec 15 2017, 6:03 AM

editors/dte/Makefile
15 ↗	(On Diff #36622)	There is no rule yes, but it's just easier to find stuff in a sorted list :) -- also stuff that starts out tidy is easier to keep tidy.

mat added inline comments.Dec 15 2017, 3:00 PM

editors/dte/Makefile
15 ↗	(On Diff #36622)	USES should be sorted (but it is nice to test it in a non sorted way from time to time to make sure that there are no hidden bugs.). I was talking about `USE_PYTHON` only.
29 ↗	(On Diff #36622)	The time is coming very soon where the old magic trick that made PORTDOCS work without the DOCS option will be gone, it's the current thing I am working on. As I wrote in D13463: If you install files in `DOCSDIR`, they MUST be guarded by `PORTDOCS`, and you MUST have a `DOCS` option. If you install files in `EXAMPLESDIR`, they MUST be guarded by `PORTEXAMPLES`, and you MUST have an `EXAMPLES` option. It does not matter if it is only one file, if you put files there, you must have the option.

Sorted USES.

I sorted USES.
Can this be committed?

editors/dte/Makefile
15 ↗	(On Diff #36622)	Where does it say it here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order-uses.html ?

In D13498#282250, @yuri wrote:

I sorted USES.
Can this be committed?

Please reconsider the 'Created by' line :)

.

Harbormaster completed remote builds in B13626: Diff 36685.Dec 17 2017, 3:10 PM

yuri marked 5 inline comments as done.Dec 17 2017, 3:11 PM

adamw accepted this revision.Dec 18 2017, 10:00 PM

This revision is now accepted and ready to land.Dec 18 2017, 10:00 PM

Closed by commit rP456692: New port: editors/dte: Small and easy to use console text editor (authored by yuri). · Explain WhyDec 18 2017, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

editors/

1 line

dte/

35 lines

3 lines

files/

patch-config_binding_default

10 lines

13 lines

Diff 36736

head/editors/Makefile

Loading...

head/editors/dte/Makefile

Loading...

head/editors/dte/distinfo

Loading...

head/editors/dte/files/patch-config_binding_default

Loading...

head/editors/dte/pkg-descr

Loading...